Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate TLS certs for unit tests #2593

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Apr 1, 2021

Issue Number

ADP-852

Overview

  • Generate new certificates for the TLS tests, because the current ones have expired.
  • Add a script to regenerate those files.

Comments

Using cardano-sl-x509 turned out to be harder than expected ... doh ... should have just used openssl.

@rvl rvl self-assigned this Apr 1, 2021
@rvl rvl requested a review from jonathanknowles April 1, 2021 06:36
@rvl rvl force-pushed the rvl/adp-852/regenerate-tls-certs branch from 73fa741 to e14b037 Compare April 1, 2021 08:57
rvl added a commit that referenced this pull request Apr 1, 2021
Until #2593 is merged.
server:
organization: "Input Output HK"
commonName: "cardano-wallet API Server"
expiryDays: 365
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 3650?

@@ -138,6 +135,51 @@ spec = describe "TLS Client Authentication" $ do
, statusMessage = "Upgrade Required"
}

--
-- Test data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -3,7 +3,7 @@
#
# NOTE: Remember to update the version matrix in README.md when
# bumping the Cardano version.
resolver: https://raw.githubusercontent.com/input-output-hk/cardano-haskell/231870a3b785f569daef0596b3a1657324c9394a/snapshots/cardano-1.25.1-GHC-8.10.4.yaml
resolver: https://raw.githubusercontent.com/input-output-hk/cardano-haskell/cd67c3f16b6c17afe76fbd3e5cefe3be0ad51147/snapshots/cardano-1.25.1.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anviking
Copy link
Member

Anviking commented Apr 1, 2021

bors r+

rvl added a commit that referenced this pull request Apr 1, 2021
Until #2593 is merged.
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 1, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 20dc1dd into master Apr 1, 2021
@iohk-bors iohk-bors bot deleted the rvl/adp-852/regenerate-tls-certs branch April 1, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants