Hash tx metadata before signing #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1115,9 +1115,10 @@ spec = describe "SHELLEY_WALLETS" $ do | |||
| let dummyChainCode = BS.replicate 32 0 | |||
| let sig = CC.xsignature $ BL.toStrict $ getFromResponse id rSig | |||
| let key = unsafeXPub $ fst (getFromResponse #getApiVerificationKey rKey) <> dummyChainCode | |||
| let msg = unsafeFromHex "A10071706C65617365207369676E20746869732E" | |||
| let _msg = unsafeFromHex "A10071706C65617365207369676E20746869732E" | |||
There was a problem hiding this comment.
this one probably we want to delete, right?
There was a problem hiding this comment.
Yeah, the string is already shown in the comment above. I deleted it.
| pure $ | ||
| Signature $ BA.convert $ | ||
| CC.sign encPwd (getRawKey addrK) $ | ||
| hash @ByteString @Blake2b_256 $ |
paweljakubas
approved these changes
Mar 31, 2021
rvl
force-pushed
the
rvl/adp-800/hash-sign-metadata
branch
from
1095188 to
9534e73
Compare
|
I added a cheap "golden" signature check to the same integration test. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 1, 2021
2589: Hash tx metadata before signing r=rvl a=rvl ### Issue Number ADP-800 ### Overview When signing tx metadata using the `signMetadata` endpoint, hash the message first before signing. Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: The build process was killed - hmm! |
rvl
force-pushed
the
rvl/adp-800/hash-sign-metadata
branch
from
5bede68 to
b023425
Compare
|
bors r+ |
|
Build succeeded: |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-800
Overview
When signing tx metadata using the
signMetadataendpoint, hash the message first before signing.