Wallet update integration tests #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
changed the title
rvl
approved these changes
May 14, 2019
| [ expectResponseCode @IO HTTP.status200 | ||
| , expectListSizeEqual 1 | ||
| , expectListItemFieldEqual 0 walletName "New great name" | ||
| , expectListItemFieldEqual 0 addressPoolGap 20 |
There was a problem hiding this comment.
The verifications could be shortened to just check walletName and walletId without reducing the effectiveness of this test.
There was a problem hiding this comment.
Yes, most probably. Although in general I prefer to verify as much as possible whenever I can (just to be safe).
| @@ -875,6 +1065,11 @@ spec = do | |||
| "passphrase": "Secure passphrase" | |||
| } |] | |||
|
|
|||
| updateNamePayload :: Text -> Payload | |||
| updateNamePayload name = Json [json| { | |||
There was a problem hiding this comment.
This is also a possibility:
Json (Object ("name" .= name))
There was a problem hiding this comment.
thanks for the hint :)
piotr-iohk
force-pushed
the
piotr/integration_tests_update_wallet
branch
from
c89b3ed to
1574f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Comments
Still working on wallet update pass integration tests. Can get them in this PR (or another one if this one gets reviewed/approved before I finish)