Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly restore bench: Make buildkite red if it fails #2566

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 17, 2021

Issue Number

ADP-804

Overview

If the nightly restore bench fails to produce a result, then make sure Buildkite has a red status.

@rvl rvl requested a review from piotr-iohk March 17, 2021 08:52
@rvl rvl self-assigned this Mar 17, 2021
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piotr-iohk
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 17, 2021
2566: Nightly restore bench: Make buildkite red if it fails r=piotr-iohk a=rvl

### Issue Number

ADP-804

### Overview

If the nightly restore bench fails to produce a result, then make sure Buildkite has a red status.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 17, 2021

Build failed:

src/Test/Integration/Scenario/API/Byron/Wallets.hs:187:59:
--
  | 1) API Specifications, BYRON_WALLETS, BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet, icarus 15 words
  | While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiByronWallet {id = ApiT {getApiT = WalletId {getWalletId = a8133bfb9b6180181e3d8e30b65cd9a036ea2c00}}, balance = ApiByronWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, discovery = DiscoverySequential, name = ApiT {getApiT = WalletName {getWalletName = "Empty Byron Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-03-17 11:46:25.97513338 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 499 % 625}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 2079}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 41}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 29}}}, time = 2021-03-17 11:44:41.8 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1000}}}}))
  | Waited longer than 90s to resolve action: "wallet is available and ready".
  | expected: Ready
  | but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 499 % 625}})
  |  
  | To rerun use: --match "/API Specifications/BYRON_WALLETS/BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet/icarus 15 words/"
  |  
  | src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:153:26:
  | 2) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_01x - Restoration from account public key preserves funds
  | While verifying ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = 6742cf41ffe896e9773df3bb4743685804d54aa6}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = NotDelegating, target = Nothing, changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "Wallet from pub key"}}, passphrase = Nothing, state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 8003 % 10000}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 7959}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 159}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 9}}}, time = 2021-03-17 12:04:17.8 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 4000}}}}
  | Waited longer than 90s to resolve action: "Wallet balance is as expected on wallet from pubKey".
  | expected: Quantity {getQuantity = 1000000}
  | but got: Quantity {getQuantity = 0}
  |  
  | To rerun use: --match "/CLI Specifications/SHELLEY_CLI_HW_WALLETS/HW_WALLETS_01x - Restoration from account public key preserves funds/"
  |  
  | Randomized with seed 1952390230


#2565

@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 17, 2021
2566: Nightly restore bench: Make buildkite red if it fails r=Anviking a=rvl

### Issue Number

ADP-804

### Overview

If the nightly restore bench fails to produce a result, then make sure Buildkite has a red status.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 17, 2021

Build failed:

 src/Test/Integration/Scenario/API/Byron/Wallets.hs:187:59:
  1) API Specifications, BYRON_WALLETS, BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet, random 18 words
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiByronWallet {id = ApiT {getApiT = WalletId {getWalletId = f31daa6eab5a81c3f19887f50a198634c0b21cb5}}, balance = ApiByronWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, discovery = DiscoveryRandom, name = ApiT {getApiT = WalletName {getWalletName = "Empty Byron Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-03-17 14:42:04.953691 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 8551 % 10000}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 2166}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 43}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 16}}}, time = 2021-03-17 14:40:53.2 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1000}}}}))
       Waited longer than 90s to resolve action: "wallet is available and ready".
       expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 8551 % 10000}})

  To rerun use: --match "/API Specifications/BYRON_WALLETS/BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet/random 18 words/"

  src/Test/Integration/Scenario/API/Byron/Wallets.hs:187:59:
  2) API Specifications, BYRON_WALLETS, BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet, icarus 24 words
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiByronWallet {id = ApiT {getApiT = WalletId {getWalletId = 431aa5aff29c2c371d50d6dada949a2571247d12}}, balance = ApiByronWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, discovery = DiscoverySequential, name = ApiT {getApiT = WalletName {getWalletName = "Empty Byron Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-03-17 14:45:16.147226 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 31 % 50}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 2166}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 43}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 16}}}, time = 2021-03-17 14:40:53.2 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1000}}}}))
       Waited longer than 90s to resolve action: "wallet is available and ready".
       expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 31 % 50}})

  To rerun use: --match "/API Specifications/BYRON_WALLETS/BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet/icarus 24 words/"

#2565

@Anviking
Copy link
Member

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 17, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 55afc32 into master Mar 17, 2021
@iohk-bors iohk-bors bot deleted the rvl/adp-804/fix-nightly-status branch March 17, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants