Change metavar from STRING to WALLET_NAME #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/tweak-meta-var
branch
from
675daf4 to
163b4c5
Compare
|
bors try |
tryBuild failed: |
Anviking
force-pushed
the
anviking/tweak-meta-var
branch
from
163b4c5 to
c5d0d97
Compare
KtorZ
reviewed
Mar 11, 2021
lib/cli/src/Cardano/CLI.hs
Outdated
| @@ -1421,7 +1421,8 @@ transactionIdArgument = argumentT $ mempty | |||
| -- | <name=STRING> | |||
| walletNameArgument :: Parser WalletName | |||
| walletNameArgument = argumentT $ mempty | |||
| <> metavar "STRING" | |||
| <> metavar "WALLET_NAME" | |||
| <> help "The name of the new wallet." | |||
There was a problem hiding this comment.
"new" implies a certain context which may not fit the use-case (although we use it only for creating wallet I think).
I'd simply stick to "Name of the wallet" for description.
There was a problem hiding this comment.
I tried making it sound more like "here you get to choose the local name of the wallet", rather than "something that must match some existing value" — but fine, let's go for "Name of the wallet"
KtorZ
approved these changes
Mar 11, 2021
- Change metavar to from STRING to WALLET_NAME - Add help text
Anviking
force-pushed
the
anviking/tweak-meta-var
branch
from
c5d0d97 to
5385720
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Comments