Asset metadata JSON schema updates #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Mar 3, 2021
| Just (Left e) -> Left e | ||
| _ -> Right u | ||
| validateDecimals u@AssetUnit{decimals} | ||
| | decimals > 0 = Right u |
There was a problem hiding this comment.
Note that the submitter also enforces that decimals are < 20
rvl
force-pushed
the
rvl/adp-770/asset-metadata-json-changes
branch
from
d7344e8 to
ae61ff8
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 4, 2021
2546: Asset metadata JSON schema updates r=rvl a=rvl ### Issue Number ADP-770 ### Overview - Increase max length of `ticker` field to 5. - Clarify OpenAPI documentation strings. - Add a `ticker` sub-field to `unit`. - Require `unit` field `decimals` to be positive. If it is 0, then `unit` wouldn't be needed. - Rename `anSignatures` to `signatures`and add `sequenceNumber` in properties of the metadata-server JSON response. These are not used yet, but I may as well update it so we're ready to check signatures. Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: #expected |
rvl
force-pushed
the
rvl/adp-770/asset-metadata-json-changes
branch
from
ae61ff8 to
531f4ca
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-770
Overview
tickerfield to 5.tickersub-field tounit.unitfielddecimalsto be positive. If it is 0, thenunitwouldn't be needed.anSignaturestosignaturesand addsequenceNumberin properties of the metadata-server JSON response. These are not used yet, but I may as well update it so we're ready to check signatures.