Recover from partial cleanupCheckpointTable db migration #2503
Conversation
| [defaults] <- runSql conn $ select ["genesis_hash", "genesis_start"] orig | ||
| let [PersistText genesisHash, PersistText genesisStart] = defaults | ||
| addColumn_ conn True (DBField WalGenesisHash) (quotes genesisHash) | ||
| addColumn_ conn True (DBField WalGenesisStart) (quotes genesisStart) | ||
|
|
||
| -- 2. Drop columns from the 'checkpoint' table | ||
| -- 2. Drop columns from the 'checkpoint' table | ||
| isFieldPresentByName conn "checkpoint" "genesis_hash" >>= \case |
There was a problem hiding this comment.
So if the checkpoint table contains the genesis_hash, we do the below migration...? Won't this always be the case? Particularly after the step above?
There was a problem hiding this comment.
I got confused by that at first too. Yet, it should work fine because we are actually with two tables here:
- The wallet table
- The checkpoint table
That migration does two things:
- It adds the genesis hash and genesis start to the wallet table.
- It removes all the protocol parameters from the checkpoint table.
Thus, once removed from the checkpoint table isFieldPresentByName conn "checkpoint" "genesis_hash" would prevent the migration from re-running again.
| @@ -448,12 +451,15 @@ migrateManually tr proxy defaultFieldValues = | |||
| , "slot_length", "epoch_length", "tx_max_size" | |||
| , "epoch_stability", "active_slot_coeff" | |||
| ] | |||
| _ <- runSql conn $ dropTable tmp | |||
| let orig = "checkpoint" | ||
| let tmp = orig <> "_tmp" | ||
|
|
||
| -- 1. Add genesis_hash and genesis_start to the 'wallet' table. | ||
| [defaults] <- runSql conn $ select ["genesis_hash", "genesis_start"] orig |
There was a problem hiding this comment.
Implicitly, this assumes that is the genesis_hash field does not exists in the wallet table, then it necessarily exists in the checkpoint table. This should be true for quite many releases back and indeed, works fine with the way the migration is written 👍
| @@ -479,7 +485,7 @@ migrateManually tr proxy defaultFieldValues = | |||
| ] | |||
|
|
|||
| dropTable table = mconcat | |||
| [ "DROP TABLE " <> table <> ";" | |||
| [ "DROP TABLE IF EXISTS " <> table <> ";" | |||
|
Build succeeded: |
Issue Number
ADP-700
Overview