Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tests and cluster run in pre-mary eras again #2493

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 5, 2021

Issue Number

ADP-695

Overview

Conditionally fund the assets faucet based on era.

The assets faucet is only supported with mary era.
@rvl rvl requested review from Anviking and piotr-iohk February 5, 2021 08:25
@rvl rvl self-assigned this Feb 5, 2021
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rvl
Copy link
Contributor Author

rvl commented Feb 5, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 5, 2021
2489: Add missing APIs for multi-asset r=rvl a=rvl

## Issue Number

ADP-698

## Overview

- Adds assets to the responses of the coin selections endpoints.
- Adds assets to the `/byron-wallets` endpoints.

## Comments



2492: API: get and list only assets associated with the wallet r=rvl a=rvl

### Issue Number

ADP-603 / ADP-604

### Overview

- The list assets endpoint now returns all assets of the wallet, not just available assets.
- The get asset endpoint checks that the asset id really is associated with the wallet.



2493: Let tests and cluster run in pre-mary eras again r=rvl a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 5, 2021

Build failed (retrying...):

This an error caused by a nix garbage collection run on buildkite.

iohk-bors bot added a commit that referenced this pull request Feb 5, 2021
2492: API: get and list only assets associated with the wallet r=rvl a=rvl

### Issue Number

ADP-603 / ADP-604

### Overview

- The list assets endpoint now returns all assets of the wallet, not just available assets.
- The get asset endpoint checks that the asset id really is associated with the wallet.



2493: Let tests and cluster run in pre-mary eras again r=rvl a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 5, 2021

Build failed (retrying...):

      readPoolProduction should never give pools with no slots after rollback - arbitrary N-slot-depth rollbacks
        +++ OK, passed 100 tests (100% number of slots <= 10).
      readStakeDistribution . putStakeDistribution == pure
        +++ OK, passed 100 tests (6% Empty distributions).
      putPoolRegistration then readPoolRegistration yields expected result
        +++ OK, passed 100 tests.
building of '/nix/store/8q2wbvfdmx56w0gq4cv7k4z3y6p6b79m-cardano-wallet-core-test-unit-2021.1.28-check' timed out after 900 seconds of silence

#2472

iohk-bors bot added a commit that referenced this pull request Feb 5, 2021
2493: Let tests and cluster run in pre-mary eras again r=rvl a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 5, 2021

Build failed:

     PUT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     PATCH /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     DELETE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     CONNECT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     TRACE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     OPTIONS /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
building of '/nix/store/86mia2kv84lphl2a31qkw30a71z4pnah-cardano-wallet-core-test-unit-2021.1.28-check' timed out after 900 seconds of silence

#2472

@Anviking
Copy link
Member

Anviking commented Feb 5, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 5, 2021
2493: Let tests and cluster run in pre-mary eras again r=Anviking a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 5, 2021

Build failed:

Failures:

  src/Test/Integration/Framework/DSL.hs:1502:16:
  1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_EXTERNAL_01 - Single Output Transaction - Shelley witnesses
       uncaught exception: ErrorCall
       getFromResponse failed to get item
       CallStack (from HasCallStack):
         error, called at src/Test/Integration/Framework/DSL.hs:1502:16 in cardano-wallet-core-integration-2021.1.28-1dPuJsGrHqTE8CGU2dhdXk:Test.Integration.Framework.DSL

  To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_EXTERNAL_01 - Single Output Transaction - Shelley witnesses/"

Randomized with seed 1825644894

@Anviking
Copy link
Member

Anviking commented Feb 5, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 5, 2021
2493: Let tests and cluster run in pre-mary eras again r=Anviking a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 5, 2021

Build failed:

    Generator for ReadPrivateKey
    Shrinker for ReadPrivateKey
    Generator for RollbackTo
    Shrinker for RollbackTo
    Generator for ReadGenesisParameters
    Shrinker for ReadGenesisParameters
  Sqlite
    Extra Properties about DB initialization
      createWallet . listWallets yields expected results
        +++ OK, passed 100 tests.
      creating same wallet twice yields an error
        +++ OK, passed 100 tests.
      removing the same wallet twice yields an error
        +++ OK, passed 100 tests.
    put . read yields a result
building of '/nix/store/hzcpjbs79862l2qijz4rq7grwx2h6z7m-cardano-wallet-core-test-unit-2021.1.28-check' timed out after 900 seconds of silence

#2472

@rvl
Copy link
Contributor Author

rvl commented Feb 6, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 6, 2021
2489: Add missing APIs for multi-asset r=rvl a=rvl

## Issue Number

ADP-698

## Overview

- Adds assets to the responses of the coin selections endpoints.
- Adds assets to the `/byron-wallets` endpoints.

## Comments



2492: API: get and list only assets associated with the wallet r=rvl a=rvl

### Issue Number

ADP-603 / ADP-604

### Overview

- The list assets endpoint now returns all assets of the wallet, not just available assets.
- The get asset endpoint checks that the asset id really is associated with the wallet.



2493: Let tests and cluster run in pre-mary eras again r=rvl a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2021

Build failed (retrying...):

  src/Test/Integration/Framework/DSL.hs:792:11:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\236(\243=\203\230\214@\n\RS^3\155\208d|\ts\202l\f\249\194\187\230\131\141\198"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 43799194956536}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 0 % 1}}, saturation = 1.0452338612952813e-5, producedBlocks = Quantity {getQuantity = 5}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 2000000000000}, retirement = Nothing, flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 41664596976421}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 87 % 250}}, saturation = 1.0440824079470887, producedBlocks = Quantity {getQuantity = 453}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 1000000}}, epochStartTime = 2021-06-01 22:24:43 UTC}), flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\187\DC1L\179}u\250\ENQ&\ETX(\194\&5\163\218\226\149\163=\v\166t\165\235\RS>V\142"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 31101895204330}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 607 % 1250}}, saturation = 1.4569031919472217, producedBlocks = Quantity {getQuantity = 727}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 100000}}, epochStartTime = 2021-02-17 18:24:43 UTC}), flags = []}])
       Waited longer than 90s to resolve action: "list pools returns non-empty list".

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

Randomized with seed 693476099

#2498

iohk-bors bot added a commit that referenced this pull request Feb 6, 2021
2492: API: get and list only assets associated with the wallet r=rvl a=rvl

### Issue Number

ADP-603 / ADP-604

### Overview

- The list assets endpoint now returns all assets of the wallet, not just available assets.
- The get asset endpoint checks that the asset id really is associated with the wallet.



2493: Let tests and cluster run in pre-mary eras again r=rvl a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2021

Build failed (retrying...):

     GET /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     PUT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     PATCH /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     DELETE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     CONNECT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     TRACE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     OPTIONS /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234
     GET /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     PUT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     PATCH /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     DELETE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     CONNECT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     TRACE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
     OPTIONS /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/1234H
building of '/nix/store/kz0xanvvs67l45br1rayv6df3p1yj792-cardano-wallet-core-test-unit-2021.1.28-check' timed out after 900 seconds of silence

#2472

iohk-bors bot added a commit that referenced this pull request Feb 6, 2021
2493: Let tests and cluster run in pre-mary eras again r=rvl a=rvl

### Issue Number

ADP-695

### Overview

Conditionally fund the assets faucet based on era.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2021

Build failed:

  src/Test/Integration/Framework/DSL.hs:792:11: 
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\187\DC1L\179}u\250\ENQ&\ETX(\194\&5\163\218\226\149\163=\v\166t\165\235\RS>V\142"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 517295348306549}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 1677 % 10000}}, saturation = 0.5030459767092352, producedBlocks = Quantity {getQuantity = 248}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 1000000}}, epochStartTime = 2021-06-02 01:29:02 UTC}), flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 505863613620885}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 0 % 1}}, saturation = 1.2002478939123791e-5, producedBlocks = Quantity {getQuantity = 4}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 2000000000000}, retirement = Nothing, flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 293704779410004}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 1531 % 2500}}, saturation = 1.8371828004482054, producedBlocks = Quantity {getQuantity = 640}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 100000}}, epochStartTime = 2021-02-17 21:29:02 UTC}), flags = []}])
       Waited longer than 90s to resolve action: "list pools returns non-empty list".

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

Randomized with seed 1898682220

#2498

@Anviking
Copy link
Member

Anviking commented Feb 8, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 8, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 804d14f into master Feb 8, 2021
@iohk-bors iohk-bors bot deleted the rvl/adp-695/faucet-non-mary branch February 8, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants