Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload swagger to bump.sh on release deployment #2385

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Upload swagger to bump.sh on release deployment #2385

merged 2 commits into from
Dec 18, 2020

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Dec 10, 2020 •
edited
Loading

Issue Number

ADP-600

Overview

  • 275956f
    Upload swagger upload to bump.sh on release

  • ca0d72f
    Add API Changes section in Release template

Comments

@piotr-iohk piotr-iohk force-pushed the piotr/adp-600/swagger-in-bump-sh branch 5 times, most recently from 0c8c70a to b551d7f Compare December 10, 2020 13:18
@piotr-iohk piotr-iohk self-assigned this Dec 10, 2020
@piotr-iohk piotr-iohk force-pushed the piotr/adp-600/swagger-in-bump-sh branch 2 times, most recently from 9d095b1 to dd53099 Compare December 14, 2020 08:32
@rvl
Copy link
Contributor

rvl commented Dec 14, 2020

Hi @piotr-iohk - I like this idea.
With bump.sh we would need to sign up for a service.
But we could also just run openapi-diff in CI (comparing current revision to most recent git tag), and it can also be run in the make_changelog.sh script.

@piotr-iohk
Copy link
Contributor Author

@rvl we discussed options last week and, for now, settled with bump.sh since it generates nice diff out of the box. See details in https://jira.iohk.io/browse/ADP-600. (Sorry, I forgot to link the jira story in the pr).

@piotr-iohk piotr-iohk force-pushed the piotr/adp-600/swagger-in-bump-sh branch from dd53099 to ca0d72f Compare December 14, 2020 14:03
@piotr-iohk piotr-iohk added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Dec 14, 2020
@piotr-iohk piotr-iohk requested review from rvl and hasufell December 14, 2020 14:08
@piotr-iohk piotr-iohk changed the title test swagger upload to bump.sh Upload swagger to bump.sh on release deployment Dec 14, 2020
@hasufell
Copy link
Contributor

@rvl see OpenAPITools/openapi-diff#200

hasufell
hasufell approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@hasufell hasufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... even if we don't really like it in the end, it's just an addition

KtorZ
KtorZ approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we seen it in action in Travis already? I don't see any build for trying this out.

@piotr-iohk
Copy link
Contributor Author

Have we seen it in action in Travis already? I don't see any build for trying this out.

I have tested it from from Travis here -> https://travis-ci.org/github/input-output-hk/cardano-wallet/builds/749565223.

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020
@iohk-bors @melmccann
Merge #2385 #2398
19f2d3b 
2385: Upload swagger to bump.sh on release deployment r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-600

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 275956f
  Upload swagger upload to bump.sh on release
  
- ca0d72f
  Add API Changes section in Release template


# Comments

 - I have tested upload from Travis into bump.sh ->  https://bump.sh/doc/cardano-wallet-test/changes ✔️ 
 - swagger should be uploaded to https://bump.sh/doc/cardano-wallet-diff/changes on release deploy step
 - added `API Changes` section to release template with a note


2398: Update docker compose with Allegra compatible tags r=rvl a=melmccann

Update docker compose to reflect the Allegra docker compatible versions 

Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Mel McCann <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 17, 2020

Build failed (retrying...):

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020
@iohk-bors
Merge #2385
53037a7 
2385: Upload swagger to bump.sh on release deployment r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-600

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 275956f
  Upload swagger upload to bump.sh on release
  
- ca0d72f
  Add API Changes section in Release template


# Comments

 - I have tested upload from Travis into bump.sh ->  https://bump.sh/doc/cardano-wallet-test/changes ✔️ 
 - swagger should be uploaded to https://bump.sh/doc/cardano-wallet-diff/changes on release deploy step
 - added `API Changes` section to release template with a note


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 17, 2020

Build failed:

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 18, 2020
@iohk-bors
Merge #2385
278d30b 
2385: Upload swagger to bump.sh on release deployment r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-600

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 275956f
  Upload swagger upload to bump.sh on release
  
- ca0d72f
  Add API Changes section in Release template


# Comments

 - I have tested upload from Travis into bump.sh ->  https://bump.sh/doc/cardano-wallet-test/changes ✔️ 
 - swagger should be uploaded to https://bump.sh/doc/cardano-wallet-diff/changes on release deploy step
 - added `API Changes` section to release template with a note


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 18, 2020 •
edited by rvl
Loading

Build failed:


Failures:

  src/Test/Integration/Scenario/API/Shelley/Addresses.hs:88:5:
  1) API Specifications, SHELLEY_ADDRESSES, BYRON_ADDRESS_LIST - Byron wallet on Shelley ep
       uncaught exception: ProcessHasExited
       ProcessHasExited "cluster didn't start correctly: [Left user error (Waited too long for: pool registration)]" (ExitFailure 1)

  To rerun use: --match "/API Specifications/SHELLEY_ADDRESSES/BYRON_ADDRESS_LIST - Byron wallet on Shelley ep/"

  2) afterAll-hook
       uncaught exception: ResultStatus
       Pending Nothing (Just "exception in beforeAll-hook (see previous failure)")

  To rerun use: --match "/afterAll-hook/"

#2427

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 18, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8b16de6 into master Dec 18, 2020
@iohk-bors iohk-bors bot deleted the piotr/adp-600/swagger-in-bump-sh branch December 18, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@hasufell hasufell hasufell approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees

@piotr-iohk piotr-iohk

Labels
IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotr-iohk @rvl @hasufell @KtorZ