Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test: Delegating addresses API roundtrip #2330

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Nov 18, 2020

Issue Number

https://jira.iohk.io/browse/ADP-461

Overview

  • 5fbc8be
    Integration test: Delegating addresses API roundtrip

  • ae49361
    Integration test: at_least must make sense

Comments

@piotr-iohk piotr-iohk added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Nov 18, 2020
@piotr-iohk piotr-iohk self-assigned this Nov 18, 2020

-- Generate first 20 addresses using payment and stake keys derived from
-- wallet API
let indexes = [0..19]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let indexes = [0..19]
let indices = [0..19]

-- Generate first 20 addresses using payment and stake keys derived from
-- wallet API
let indexes = [0..19]
generatedAddresses <- forM indexes $ \index -> do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
generatedAddresses <- forM indexes $ \index -> do
generatedAddresses <- forM indices $ \index -> do

Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 19, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2d76a4c into master Nov 19, 2020
@iohk-bors iohk-bors bot deleted the piotr/moar-tests branch November 19, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants