Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SMASH integration test #2319

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Add SMASH integration test #2319

merged 3 commits into from
Nov 17, 2020

Conversation

hasufell
Copy link
Contributor

@hasufell hasufell commented Nov 13, 2020 •
edited
Loading

Issue Number

https://jira.iohk.io/browse/ADP-478

  • add integration test for SMASH via file stub server

@hasufell
Copy link
Contributor Author

@piotr-iohk can you think of more scenarios?

@hasufell hasufell requested review from piotr-iohk and KtorZ November 13, 2020 16:47
@hasufell hasufell force-pushed the hasufell/ADP-478/integration-test branch from e2aea16 to 6209bb4 Compare November 16, 2020 12:44
@hasufell hasufell requested a review from KtorZ November 16, 2020 12:44
@hasufell hasufell force-pushed the hasufell/ADP-478/integration-test branch from 6209bb4 to 3e7e73a Compare November 16, 2020 12:53
KtorZ
KtorZ reviewed Nov 16, 2020
View reviewed changes
lib/shelley/test/integration/Main.hs
ByronTransactions.spec @n
ByronHWWallets.spec @n

-- possible conflict with StakePools
Settings.spec @n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hasufell hasufell force-pushed the hasufell/ADP-478/integration-test branch from 3e7e73a to db43c99 Compare November 17, 2020 10:24
piotr-iohk
piotr-iohk approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/StakePools.hs Show resolved Hide resolved
@hasufell hasufell force-pushed the hasufell/ADP-478/integration-test branch from 3b742b4 to badf769 Compare November 17, 2020 13:47
KtorZ
KtorZ approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

lib/core/test/unit/Cardano/Pool/DB/Properties.hs
setup = run $ atomically cleanDB

prop = do
run $ atomically $ putDelistedPools (Set.toList pools)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably, this ☝️ is setup, but I am neat-picking :)

KtorZ
KtorZ reviewed Nov 17, 2020
View reviewed changes
lib/core-integration/src/Test/Integration/Framework/DSL.hs
@@ -607,6 +609,18 @@ updateMetadataSource ctx t = do
}
} |]

bracketSettings :: (MonadIO m, MonadCatch m) => Context t -> m () -> m ()
bracketSettings ctx action = do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have leveraged resourcet here for allocating / freeing settings.

@hasufell
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 17, 2020
@iohk-bors
Merge #2319
d2ab232 
2319: Add SMASH integration test r=hasufell a=hasufell

# Issue Number

https://jira.iohk.io/browse/ADP-478

* add integration test for SMASH via file stub server

Co-authored-by: Julian Ospald <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 17, 2020 •
edited by Anviking
Loading

Build failed:

Timed out after

 STAKE_POOLS_LIST_05 - Fails without query parameter
    STAKE_POOLS_LIST_06 - NonMyopicMemberRewards are 0 when stake is 0
      # PENDING: This assumption seems false, for some reasons...
    STAKE_POOLS_GARBAGE_COLLECTION_01 - retired pools are garbage collected on schedule and not before

and a lot of Ok....
#2337

@hasufell
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 17, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit a604358 into master Nov 17, 2020
@iohk-bors iohk-bors bot deleted the hasufell/ADP-478/integration-test branch November 17, 2020 16:51
Anviking added a commit that referenced this pull request Nov 25, 2020
@Anviking
Mark STAKE_POOLS_SMASH_01 pending
60f5a59 
-j 8 was enabled on 2020-11-04. There _is_ a timeout two days after. But
timeouts only became _frequent_ on 2020-11-17.

 * [2020-11-06]|#2297 (comment)]
 * [2020-11-17|#2319 (comment)]
 * [2020-11-18|#2329 (comment)]
 * [2020-11-18|#2329 (comment)]
 * [2020-11-19|#2335 (comment)]
 * [2020-11-19|#2335 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-24|#2338 (comment)]
 * [2020-11-24|#2343 (comment)]
Anviking added a commit that referenced this pull request Nov 25, 2020
@Anviking
Mark STAKE_POOLS_SMASH_01 pending
8512c29 
-j 8 was enabled on 2020-11-04. There _is_ a timeout two days after. But
timeouts only became _frequent_ on 2020-11-17.

 * [2020-11-06]|#2297 (comment)]
 * [2020-11-17|#2319 (comment)]
 * [2020-11-18|#2329 (comment)]
 * [2020-11-18|#2329 (comment)]
 * [2020-11-19|#2335 (comment)]
 * [2020-11-19|#2335 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-24|#2338 (comment)]
 * [2020-11-24|#2343 (comment)]
Anviking added a commit that referenced this pull request Nov 25, 2020
@Anviking
Mark STAKE_POOLS_SMASH_01 pending
98f9dc6 
-j 8 was enabled on 2020-11-04. There _is_ a timeout two days after. But
timeouts only became _frequent_ on 2020-11-17.

 * [2020-11-06]|#2297 (comment)]
 * [2020-11-17|#2319 (comment)]
 * [2020-11-18|#2329 (comment)]
 * [2020-11-18|#2329 (comment)]
 * [2020-11-19|#2335 (comment)]
 * [2020-11-19|#2335 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-23|#2338 (comment)]
 * [2020-11-24|#2338 (comment)]
 * [2020-11-24|#2343 (comment)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasufell @KtorZ @piotr-iohk