Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Try lowering from -j 8 to -j 3 #2310

Closed
wants to merge 1 commit into from

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Nov 11, 2020

Issue Number

ADP-466 / #2292 / #2295

Overview

  • Lower integration test parallelism from -j 8 to -j 3 in buildkite and hydra

Comments

We have many problems with:
TTL tests
unit tests timing out

The unit tests on master barely seem to be failing
https://buildkite.com/input-output-hk/cardano-wallet
where the integration tests are not run.

I wonder if lowering the parallelism puts less strain on the machines
running the tests, and makes the tests pass more.

If it doesn't help, we should revert back to -j 8. But it's worth a shot, I think.

Results so far

Maybe this is not working...

We have many problems with:
  TTL tests
  unit tests timing out

The unit tests on master barely seem to be failing
https://buildkite.com/input-output-hk/cardano-wallet

I wonder if lowering the parallelism puts less strain on the machines
running the tests, and makes the tests pass more.
@Anviking Anviking self-assigned this Nov 11, 2020
@Anviking Anviking requested a review from rvl November 11, 2020 09:45
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Nov 11, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 11, 2020

try

Build failed:

src/Test/Integration/Scenario/API/Byron/Addresses.hs:432:13:
--
  | 1) API Specifications, BYRON_ADDRESSES, ADDRESS_IMPORT_05 - I can import 15000 of addresses
  | While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [])
  | Waited longer than 90s to resolve action: "Addresses are imported".
  | expected: 15000
  | but got: 0

@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Nov 11, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 11, 2020

try

Build failed:

@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 11, 2020

👎 Rejected by too few approved reviews

@Anviking
Copy link
Member Author

bors try
meant this

iohk-bors bot added a commit that referenced this pull request Nov 11, 2020
@Anviking
Copy link
Member Author

bors try

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 11, 2020

try

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 11, 2020

try

Build succeeded:

@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Nov 11, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 11, 2020

try

Build failed:

    rollback
      Can rollback to any arbitrary known checkpoint
        +++ OK, passed 100 tests.
      Correctly re-construct tx history on rollbacks
        +++ OK, passed 400 tests:

@Anviking Anviking closed this Nov 12, 2020
@Anviking Anviking deleted the anviking/ADP-466/lower-parallelism branch November 12, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant