Update the API specification to reflect the minimum number of inputs returned by selectCoins.
#2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the minimum number of inputs from `0` to `1`.
The corresponding `ApiCoinSelection` type specifies a `NonEmpty` list of
`ApiCoinSelectionInput` values:
```
data ApiCoinSelection (n :: NetworkDiscriminant) = ApiCoinSelection
{ inputs :: !(NonEmpty (ApiCoinSelectionInput n))
, outputs :: ![ApiCoinSelectionOutput n]
, change :: ![ApiCoinSelectionChange n]
, certificates :: Maybe (NonEmpty ApiCertificate)
} deriving (Eq, Generic, Show)
```
KtorZ
approved these changes
Oct 22, 2020
paweljakubas
approved these changes
Oct 22, 2020
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 22, 2020
2261: Update the API specification to reflect the minimum number of inputs returned by `selectCoins`. r=KtorZ a=jonathanknowles # Issue Related to #2244. # Overview This PR updates the API specification for the `selectCoins` operation, changing the minimum number of inputs from `0` to `1` in the returned coin selection. This matches the existing `ApiCoinSelection` type, which specifies a `NonEmpty` list of `ApiCoinSelectionInput` values: ```hs data ApiCoinSelection (n :: NetworkDiscriminant) = ApiCoinSelection { inputs :: !(NonEmpty (ApiCoinSelectionInput n)) , outputs :: ![ApiCoinSelectionOutput n] , change :: ![ApiCoinSelectionChange n] , certificates :: Maybe (NonEmpty ApiCertificate) } deriving (Eq, Generic, Show) ``` Co-authored-by: Jonathan Knowles <[email protected]>
|
Timed out. |
|
bors retry |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/fix-coin-selection-inputs-min-bound
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #2244.
Overview
This PR updates the API specification for the
selectCoinsoperation, changing the minimum number of inputs from0to1in the returned coin selection.This matches the existing
ApiCoinSelectiontype, which specifies aNonEmptylist ofApiCoinSelectionInputvalues: