-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make addresses separate category in swagger #2185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
added
the
RESOLVING ISSUE
Mark a PR as resolving issues, for auto-generated CHANGELOG
label
Sep 25, 2020
KtorZ
reviewed
Sep 25, 2020
specifications/api/swagger.yaml
Outdated
@@ -2160,7 +2160,7 @@ x-tagGroups: | |||
- name: Shelley (Sequential) | |||
tags: | |||
- Wallets | |||
- Addresses | |||
- Shelley Addresses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erf, this sort of breaks the pattern 😅 ... Shall we maybe have a separate group under Misc called Tools
or Utils
?
piotr-iohk
force-pushed
the
piotr/fix-inspect-addr-swagger
branch
from
September 25, 2020 19:49
796c66a
to
58d237f
Compare
KtorZ
approved these changes
Sep 28, 2020
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 28, 2020
2185: Make addresses separate category in swagger r=piotr-iohk a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview - 796c66a Make inspect addresses separate category inside Misc in swagger # Comments Clicking at "Inspect Address" inside "Byron Addresses" would jump to "Addresses -> Inspect Address", which was a bit awkward. (https://input-output-hk.github.io/cardano-wallet/api/edge/#tag/Byron-Addresses) Perhaps it deserves separate category? ![Screenshot from 2020-09-25 21-49-20](https://user-images.githubusercontent.com/42900201/94309914-1a901f80-ff79-11ea-8bfd-3db13bb05c18.png) Co-authored-by: Piotr Stachyra <[email protected]>
Build failed:
|
KtorZ
force-pushed
the
piotr/fix-inspect-addr-swagger
branch
from
September 28, 2020 08:47
58d237f
to
a0e4f11
Compare
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Make inspect addresses separate category inside Misc in swagger
Comments
Clicking at "Inspect Address" inside "Byron Addresses" would jump to "Addresses -> Inspect Address", which was a bit awkward.
(https://input-output-hk.github.io/cardano-wallet/api/edge/#tag/Byron-Addresses)
Perhaps it deserves separate category?