Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make addresses separate category in swagger #2185

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Sep 25, 2020

Issue Number

Overview

  • 796c66a
    Make inspect addresses separate category inside Misc in swagger

Comments

Clicking at "Inspect Address" inside "Byron Addresses" would jump to "Addresses -> Inspect Address", which was a bit awkward.
(https://input-output-hk.github.io/cardano-wallet/api/edge/#tag/Byron-Addresses)

Perhaps it deserves separate category?

Screenshot from 2020-09-25 21-49-20

@piotr-iohk piotr-iohk added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Sep 25, 2020
@piotr-iohk piotr-iohk requested a review from KtorZ September 25, 2020 15:17
@piotr-iohk piotr-iohk self-assigned this Sep 25, 2020
@@ -2160,7 +2160,7 @@ x-tagGroups:
- name: Shelley (Sequential)
tags:
- Wallets
- Addresses
- Shelley Addresses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erf, this sort of breaks the pattern 😅 ... Shall we maybe have a separate group under Misc called Tools or Utils ?

@piotr-iohk piotr-iohk force-pushed the piotr/fix-inspect-addr-swagger branch from 796c66a to 58d237f Compare September 25, 2020 19:49
@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 28, 2020
2185: Make addresses separate category in swagger r=piotr-iohk a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 796c66a
  Make inspect addresses separate category inside Misc in swagger


# Comments

Clicking at "Inspect Address" inside "Byron Addresses" would jump to "Addresses -> Inspect Address", which was a bit awkward.
(https://input-output-hk.github.io/cardano-wallet/api/edge/#tag/Byron-Addresses)

Perhaps it deserves separate category?

![Screenshot from 2020-09-25 21-49-20](https://user-images.githubusercontent.com/42900201/94309914-1a901f80-ff79-11ea-8bfd-3db13bb05c18.png)


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 28, 2020

Build failed:

#2196

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:151:9: 
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01 - Cannot join existent stakepool with wrong password
       uncaught exception: IOException of type UserError
       user error (Pattern match failure in do expression at src/Test/Integration/Scenario/API/Shelley/StakePools.hs:151:9-14)

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01 - Cannot join existent stakepool with wrong password/"

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:165:9: 
  2) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them
       uncaught exception: IOException of type UserError
       user error (Pattern match failure in do expression at src/Test/Integration/Scenario/API/Shelley/StakePools.hs:165:9-14)

  To rerun use: --match "/API Specifications/SHELLEY_

@KtorZ KtorZ force-pushed the piotr/fix-inspect-addr-swagger branch from 58d237f to a0e4f11 Compare September 28, 2020 08:47
@KtorZ
Copy link
Member

KtorZ commented Sep 28, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 28, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit e2e4d9a into master Sep 28, 2020
@iohk-bors iohk-bors bot deleted the piotr/fix-inspect-addr-swagger branch September 28, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants