Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API docs on saturation, rewards, and relative stake #2162

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Update API docs on saturation, rewards, and relative stake #2162

merged 1 commit into from
Sep 22, 2020

Conversation

Anviking
Copy link
Member

Issue Number

#2155

Overview

  • Tweaked API docs

Comments

  • Not sure if we should rush this to be in the release or not

Anviking
Anviking commented Sep 22, 2020
View reviewed changes
specifications/api/swagger.yaml Show resolved Hide resolved
specifications/api/swagger.yaml Show resolved Hide resolved
specifications/api/swagger.yaml Show resolved Hide resolved
KtorZ
KtorZ approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we want to release on 1.20.0, I'd like to have that merged unless you think there are good reasons to hold on?

I supposed you checked some of these claims with Jared & al ?

@Anviking Anviking self-assigned this Sep 22, 2020
@Anviking Anviking marked this pull request as ready for review September 22, 2020 12:13
@Anviking
Copy link
Member Author

Anviking commented Sep 22, 2020 •
edited
Loading

bors r+

I supposed you checked some of these claims with Jared & al ?

I double-checked with Philipp now.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 22, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 226c1c8 into master Sep 22, 2020
@iohk-bors iohk-bors bot deleted the anviking/2155/rel-stake-docs branch September 22, 2020 14:14
@Anviking Anviking mentioned this pull request Sep 24, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @KtorZ