stack.yaml: Completely disable RDRAND support in cryptonite #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
IMPROVEMENT
KtorZ
approved these changes
Sep 7, 2020
|
Ja. Damn AMD CPUs... |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 7, 2020
2100: cardano-node: 1.19.0 -> 1.19.1 r=rvl a=rvl ### Issue Number None ### Overview - Updates cardano-node to [1.19.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.19.1) - Back to a URL snapshot - hopefully prevents stack snapshot caching issues. - Completely disable RDRAND in cryptonite using a cabal flag. ### Comments - Needs input-output-hk/cardano-haskell#26 merged first. 2115: stack.yaml: Completely disable RDRAND support in cryptonite r=rvl a=rvl ### Issue Number Relates to ADP-428. ### Overview Ensures that RDRAND can never be the sole source of RNG entropy. To generate mnemonics it goes through cryptonite `Crypto.Random.Entropy.getEntropy`. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows). Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: IOHK <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
rvl
force-pushed
the
rvl/adp-428/disable-rdrand
branch
from
989539b to
dc160c6
Compare
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 8, 2020
2100: cardano-node: 1.19.0 -> 1.19.1 r=rvl a=rvl ### Issue Number None ### Overview - Updates cardano-node to [1.19.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.19.1) - Back to a URL snapshot - hopefully prevents stack snapshot caching issues. - Completely disable RDRAND in cryptonite using a cabal flag. ### Comments - Needs input-output-hk/cardano-haskell#26 merged first. 2115: stack.yaml: Completely disable RDRAND support in cryptonite r=rvl a=rvl ### Issue Number Relates to ADP-428. ### Overview Ensures that RDRAND can never be the sole source of RNG entropy. To generate mnemonics it goes through cryptonite `Crypto.Random.Entropy.getEntropy`. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows). Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Relates to ADP-428.
Overview
Ensures that RDRAND can never be the sole source of RNG entropy.
To generate mnemonics it goes through cryptonite
Crypto.Random.Entropy.getEntropy. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows).