Add metadata to transaction layer #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
ADDING FEATURE
Merged
KtorZ
force-pushed
the
rvl/2077/tx-metadata
branch
from
9660fd1 to
c003df8
Compare
KtorZ
reviewed
Aug 31, 2020
lib/core/src/Cardano/Wallet.hs
Outdated
| @@ -1591,6 +1592,7 @@ signTx ctx wid pwd (UnsignedTx inpsNE outsNE) = db & \DBLayer{..} -> do | |||
| nl = ctx ^. networkLayer @t | |||
| inps = NE.toList inpsNE | |||
| outs = NE.toList outsNE | |||
| md = Nothing -- no metadata | |||
There was a problem hiding this comment.
Shouldn't this be better left as an argument as well ?
rvl
force-pushed
the
rvl/2077/tx-metadata
branch
from
b9d1b1a to
d7ca998
Compare
rvl
force-pushed
the
rvl/2073/mkstdtx
branch
from
90797e8 to
1ef320e
Compare
rvl
force-pushed
the
rvl/2073/mkstdtx
branch
from
1ef320e to
30d70f6
Compare
|
bors try |
tryBuild succeeded |
KtorZ
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-307 / #2073
Overview
mkStdTxso that transactions can be submitted with metadata.Comments
Based on the branch of PR #2079.