Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the maximum address pool gap to 100 000 #2050

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Increase the maximum address pool gap to 100 000 #2050

merged 2 commits into from
Aug 24, 2020

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Aug 18, 2020

Issue Number

N/A

Overview

  • I have increased the maximum address pool gap to 100 000

Comments

  • NOTE 1: This was done originally when exploring options to help exchanges with large Byron wallets, discarded, but now resurrected as needed by other exchanges who wants to leverage Shelley wallets NOW. I still think that we should work on a dedicated wallet scheme for exchange, but in the meantime, this would do.

  • NOTE 2: I originally tested to restore a Shelley wallet with a gap of 100k on Mainnet, it took a bit less than 8 hours BUT, this was before we find and fix the issue with the logger so I'd like to re-conduct such test with the fix on to see.

@KtorZ KtorZ requested a review from piotr-iohk August 18, 2020 15:32
@KtorZ KtorZ self-assigned this Aug 18, 2020
@KtorZ KtorZ added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Aug 18, 2020
jonathanknowles
jonathanknowles approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a question and a couple of suggestions. (See comments.)

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery/Sequential.hs Outdated Show resolved Hide resolved
lib/core/test/unit/Cardano/Wallet/Primitive/AddressDiscovery/SequentialSpec.hs Show resolved Hide resolved
lib/core/test/unit/Cardano/Wallet/Primitive/AddressDiscovery/SequentialSpec.hs Show resolved Hide resolved
@KtorZ KtorZ force-pushed the KtorZ/increase-maximum-address-pool-gap-to-100k branch 2 times, most recently from 85ec3e4 to ff9d6e8 Compare August 20, 2020 10:22
@KtorZ
Copy link
Member Author

KtorZ commented Aug 20, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 20, 2020
@iohk-bors @KtorZ
Merge #2050
2095d68 
2050: Increase the maximum address pool gap to 100 000 r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

N/A

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have increased the maximum address pool gap to 100 000

# Comments

<!-- Additional comments or screenshots to attach if any -->

- NOTE 1: This was done originally when exploring options to help exchanges with large Byron wallets, discarded, but now resurrected as needed by other exchanges who wants to leverage Shelley wallets NOW. I still think that we should work on a dedicated wallet scheme for exchange, but in the meantime, this would do. 

- NOTE 2: I originally tested to restore a Shelley wallet with a gap of 100k on Mainnet, it took a bit less than 8 hours BUT, this was before we find and fix the issue with the logger so I'd like to re-conduct such test with the fix on to see. 

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 20, 2020 •
edited by KtorZ
Loading

Build failed

Progress 5/6: cardano-wallet-2020.8.3
Timed out after 45 minutes.

@KtorZ
Copy link
Member Author

KtorZ commented Aug 24, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 24, 2020
@iohk-bors @KtorZ
Merge #2050
cfff119 
2050: Increase the maximum address pool gap to 100 000 r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

N/A

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have increased the maximum address pool gap to 100 000

# Comments

<!-- Additional comments or screenshots to attach if any -->

- NOTE 1: This was done originally when exploring options to help exchanges with large Byron wallets, discarded, but now resurrected as needed by other exchanges who wants to leverage Shelley wallets NOW. I still think that we should work on a dedicated wallet scheme for exchange, but in the meantime, this would do. 

- NOTE 2: I originally tested to restore a Shelley wallet with a gap of 100k on Mainnet, it took a bit less than 8 hours BUT, this was before we find and fix the issue with the logger so I'd like to re-conduct such test with the fix on to see. 

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 24, 2020 •
edited by KtorZ
Loading

Build failed

    Failures:
    
      src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:375:17: 
      1) CLI Specifications, HW_WALLETS_06 - Test parameters, Address pool gap invalid, Pool gap: -1
           "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100000.\n\nUsage: cardano-wallet wallet create from-public-key [--port INT] STRING\n                                                    [--address-pool-gap INT]\n                                                    ACCOUNT_PUBLIC_KEY\n  Create a wallet using a public account key.\n" does not contain "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100."
    
      To rerun use: --match "/CLI Specifications/HW_WALLETS_06 - Test parameters/Address pool gap invalid/Pool gap: -1/"
    
      src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:375:17: 
      2) CLI Specifications, HW_WALLETS_06 - Test parameters, Address pool gap invalid, Pool gap: 0
           "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100000.\n\nUsage: cardano-wallet wallet create from-public-key [--port INT] STRING\n                                                    [--address-pool-gap INT]\n                                                    ACCOUNT_PUBLIC_KEY\n  Create a wallet using a public account key.\n" does not contain "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100."
    
      To rerun use: --match "/CLI Specifications/HW_WALLETS_06 - Test parameters/Address pool gap invalid/Pool gap: 0/"
    
      src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:375:17: 
      3) CLI Specifications, HW_WALLETS_06 - Test parameters, Address pool gap invalid, Pool gap: 9
           "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100000.\n\nUsage: cardano-wallet wallet create from-public-key [--port INT] STRING\n                                                    [--address-pool-gap INT]\n                                                    ACCOUNT_PUBLIC_KEY\n  Create a wallet using a public account key.\n" does not contain "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100."
    
      To rerun use: --match "/CLI Specifications/HW_WALLETS_06 - Test parameters/Address pool gap invalid/Pool gap: 9/"
    
      src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:375:17: 
      4) CLI Specifications, HW_WALLETS_06 - Test parameters, Address pool gap invalid, Pool gap: 100001
           "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100000.\n\nUsage: cardano-wallet wallet create from-public-key [--port INT] STRING\n                                                    [--address-pool-gap INT]\n                                                    ACCOUNT_PUBLIC_KEY\n  Create a wallet using a public account key.\n" does not contain "option --address-pool-gap: An address pool gap must be a natural number between 10 and 100."
    
      To rerun use: --match "/CLI Specifications/HW_WALLETS_06 - Test parameters/Address pool gap invalid/Pool gap: 100001/"

KtorZ added 2 commits August 24, 2020 15:02
@KtorZ
increase the maximum address pool gap to 100 000
b418744 
  This is probably _unsound_ and will revert if it turns out to be a bad experiment.
@KtorZ
remove redundant and now overly long gap max test in command-line sce…
cd0878f 
…narios
@KtorZ KtorZ force-pushed the KtorZ/increase-maximum-address-pool-gap-to-100k branch from f72570a to cd0878f Compare August 24, 2020 13:03
@KtorZ
Copy link
Member Author

KtorZ commented Aug 24, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 24, 2020
@iohk-bors @KtorZ
Merge #2050
ee1bc77 
2050: Increase the maximum address pool gap to 100 000 r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

N/A

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have increased the maximum address pool gap to 100 000

# Comments

<!-- Additional comments or screenshots to attach if any -->

- NOTE 1: This was done originally when exploring options to help exchanges with large Byron wallets, discarded, but now resurrected as needed by other exchanges who wants to leverage Shelley wallets NOW. I still think that we should work on a dedicated wallet scheme for exchange, but in the meantime, this would do. 

- NOTE 2: I originally tested to restore a Shelley wallet with a gap of 100k on Mainnet, it took a bit less than 8 hours BUT, this was before we find and fix the issue with the logger so I'd like to re-conduct such test with the fix on to see. 

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 24, 2020

Timed out

@KtorZ
Copy link
Member Author

KtorZ commented Aug 24, 2020

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 24, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 7697581 into master Aug 24, 2020
@iohk-bors iohk-bors bot deleted the KtorZ/increase-maximum-address-pool-gap-to-100k branch August 24, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanknowles jonathanknowles jonathanknowles approved these changes

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@KtorZ KtorZ

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @jonathanknowles