Run coin selection properties with non-zero withdrawal #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
Aug 10, 2020
lib/core/test/unit/Cardano/Wallet/Primitive/CoinSelectionSpec.hs
Outdated
Show resolved
Hide resolved
Anviking
force-pushed
the
anviking/2006/wdrl-in-props
branch
from
01771b1 to
da30d07
Compare
Anviking
force-pushed
the
anviking/2006/wdrl-in-props
branch
from
da30d07 to
65c48bc
Compare
Anviking
commented
Aug 10, 2020
| shrinkWdrl = map Quantity . shrink . getQuantity | ||
| arbitrary = do | ||
| utxo <- arbitrary | ||
| wdrl <- Quantity <$> frequency [(65, return 0), (35, arbitrary)] |
There was a problem hiding this comment.
65% no withdrawal like previously
Anviking
force-pushed
the
anviking/2006/wdrl-in-props
branch
from
e03d29f to
abe7916
Compare
lib/core/test/unit/Cardano/Wallet/Primitive/CoinSelectionSpec.hs
Outdated
Show resolved
Hide resolved
paweljakubas
approved these changes
Aug 10, 2020
When looking at the testing for coin selection I noticed these properties assumed withdrawal=0. By extending CoinSelProp we can also test what happens when withdrawal /= 0. They pass. I don't think there's a problem here.
Anviking
force-pushed
the
anviking/2006/wdrl-in-props
branch
from
abe7916 to
7d2d929
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 11, 2020
2014: Run coin selection properties with non-zero withdrawal r=Anviking a=Anviking # Issue Number From looking at #2006, but surely not related. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I added a withdrawal field to `CoinSelProp` and used it in coin selection properties # Comments - I'm not that familiar with the coin selection, but this seems like a good idea, right? <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
Anviking
added
the
IMPROVEMENT
Timed out |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
From looking at #2006, but surely not related.
Overview
CoinSelPropand used it in coin selection propertiesComments