review guard condition on self withdrawl redemption #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a lot easier for clients to deal with rewards. One can always give 'self' and simply let the backend decides whether or not rewards should be redeemed. For external wallets however, it could be quite counter-intuitive to succeed in the case there are no rewards in the target wallet so we still error in that case.
As per previous commit.
KtorZ
added
the
ADDING FEATURE
|
bors try |
paweljakubas
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
LGTM. Before this PR, we had the check always ON, for both ExternalWithdrawal and SelfWithdrawal cases when withdrawal = 0 and this could impede SelfWithdrawal txs we don't want to be stopped. Now we will only do it for ExternalWithdrawal case, meaning we will not end up with ErrWithdrawalNotWorth error in SelfWithdrawal case. Which is reasonable change.
|
Hydra is failing on the MacOS integration test, failure seems completely unrelated. So, moving on 👍 |
tryTimed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1965
Overview
728ab75
📍 change integration scenario to always allow redeeming from self
This makes it a lot easier for clients to deal with rewards. One can always give 'self' and simply let the backend decides whether or not rewards should be redeemed. For external wallets however, it could be quite counter-intuitive to succeed in the case there are no rewards in the target wallet so we still error in that case.
278c9a3
📍 move rewards redemption guard to only apply to external redemptions
As per previous commit.
029da7f
📍 improve and adjust API documentation on withdrawal redemption
Comments