Simplify Shelley listPools operation.
#1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justification: name is consistent with type.
Justification: name is consistent with type.
Justification: name is consistent with type.
Explain to the reader might they might want to look at `readPoolLifeCycleStatus`.
Justification: name is consistent with type.
|
bors try |
tryBuild succeeded |
jonathanknowles
added
the
IMPROVEMENT
rvl
approved these changes
Jul 13, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 13, 2020
1898: Simplify Shelley `listPools` operation. r=jonathanknowles a=jonathanknowles # Issue Number #1847 # Overview This PR tidies up some loose ends from PR #1847: - [x] Coalesces the various pool DB data merging functions into a single function with a more straightforward type. - [x] Simplifies the definition of `readPoolDbData`. - [x] Revises comments for `readPool{Registration, Retirement}` functions. Co-authored-by: Jonathan Knowles <[email protected]>
Timed out |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1847
Overview
This PR tidies up some loose ends from PR #1847:
readPoolDbData.readPool{Registration, Retirement}functions.