Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction get by id check to Byron API and CLI tests #1804

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Add transaction get by id check to Byron API and CLI tests #1804

merged 1 commit into from
Jun 26, 2020

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

#1789

Overview

  • bf4da8f
    Add transaction get by id check to Byron API and CLI tests

Comments

Added checks for "get tx by id" also for Byron wallets.

@piotr-iohk piotr-iohk requested a review from paweljakubas June 26, 2020 16:45
@piotr-iohk piotr-iohk mentioned this pull request Jun 26, 2020
Closed
paweljakubas
paweljakubas approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotr-iohk piotr-iohk self-assigned this Jun 26, 2020
@piotr-iohk piotr-iohk added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Jun 26, 2020
@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 26, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 4894cdd into master Jun 26, 2020
@iohk-bors iohk-bors bot deleted the piotr/test_tx_by_id branch June 26, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @paweljakubas