Jörmungandr 0.9.0 #1779

KtorZ · 2020-06-18T17:44:50Z

Issue Number

Overview

9071b4e
📍 bump jormungandr.nix to use 0.9.0-rc1
cc4e904
📍 re-generate jormungandr arbitrary blocks
8005030
📍 fix missing configuration param & fragment in Jörmungandr Binary
bf2634f
📍 bump jormungandr integration to 0.9.0
cf90092
📍 bump iohk-nix to get a more recent version of the rust compiler
4e835cc
📍 Fix jormungandr windows zip URL
The v was removed from the filenames.
99ab316
📍 align jormungandr error messages for addresses with cardano-node
2ae6107
📍 make chimeric account conversion tight to the underlying key scheme.
ShelleyKey and cardano-node requires the reward account public key to be hashed, whereas Jörmungandr requires the raw
public key. We initially cope with that directly in the backend-specific packages but it doesn't quite work and
the engine also needs to be agnostic to the way accounts are obtained from the wallet's state
b0dbd2c
📍 only disable fetching reward account on ShelleyKey
And make it log a warning about this feature being temporarily disabled.

rvl · 2020-06-25T12:01:58Z

bors try

rvl · 2020-06-25T12:04:20Z

bors try-

I forgot - we are only running jormungandr tests nightly anyway.

KtorZ · 2020-06-25T13:36:54Z

@rvl I think they still run in Hydra though, so bors would eventually run them.

KtorZ · 2020-06-25T13:37:20Z

I still have two failures locally.. rewards don't accumulate on some scenario, which is odd.

KtorZ · 2020-06-25T15:02:23Z

    -- TODO: issue #1750 re-enable querying reward balance when it's faster
    reward <- withWorkerCtx @_ @s @k ctx wid liftE liftE $ \wrk -> liftHandler $
        if False
            then W.fetchRewardBalance @_ @s @t @k wrk wid
            else pure $ Quantity 0

AH! It only took me a few hours before I found this :|

piotr-iohk · 2020-06-25T15:19:49Z

I see these two locally:

Failures:

  test/integration/Test/Integration/Jormungandr/Scenario/API/StakePools.hs:328:5: 
  1) API Specifications STAKE_POOLS_JOIN_04 - Rewards accumulate and stop
       uncaught exception: IOException of type UserError
       user error (waited more than 3min for action to eventually resolve. Action: "Wallet gets rewards")

  To rerun use: --match "/API Specifications/STAKE_POOLS_JOIN_04 - Rewards accumulate and stop/"

  test/integration/Test/Integration/Jormungandr/Scenario/API/StakePools.hs:386:5: 
  2) API Specifications STAKE_POOLS_JOIN_04 -Delegate, stop in the next epoch, and still earn rewards
       uncaught exception: IOException of type UserError
       user error (waited more than 3min for action to eventually resolve. Action: "wallet gets rewards")

  To rerun use: --match "/API Specifications/STAKE_POOLS_JOIN_04 -Delegate, stop in the next epoch, and still earn rewards/"

Randomized with seed 48877705

I saw the comment #1779 (comment), not sure if these were supposed to be addressed or not?

KtorZ · 2020-06-25T15:35:28Z

@piotr-iohk indeed... I thought I fixed it, but it was something else which I just found (and fixed). What about now :) ?

KtorZ · 2020-06-25T15:37:13Z

bors try

piotr-iohk

LGTM

iohk-bors · 2020-06-25T16:05:21Z

try

Build failed

buildkite/cardano-wallet

KtorZ · 2020-06-25T16:11:24Z

bors r+

1779: Jörmungandr 0.9.0 r=KtorZ a=KtorZ # Issue Number  # Overview  - 9071b4e 📍 **bump jormungandr.nix to use 0.9.0-rc1** - cc4e904 📍 **re-generate jormungandr arbitrary blocks** - 8005030 📍 **fix missing configuration param & fragment in Jörmungandr Binary** - bf2634f 📍 **bump jormungandr integration to 0.9.0** - cf90092 📍 **bump iohk-nix to get a more recent version of the rust compiler** - 4e835cc 📍 **Fix jormungandr windows zip URL** The v was removed from the filenames. - 99ab316 📍 **align jormungandr error messages for addresses with cardano-node** - 2ae6107 📍 **make chimeric account conversion tight to the underlying key scheme.** ShelleyKey and cardano-node requires the reward account public key to be hashed, whereas Jörmungandr requires the raw public key. We initially cope with that directly in the backend-specific packages but it doesn't quite work and the engine also needs to be agnostic to the way accounts are obtained from the wallet's state - b0dbd2c 📍 **only disable fetching reward account on ShelleyKey** And make it log a warning about this feature being temporarily disabled. Co-authored-by: KtorZ <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>

iohk-bors · 2020-06-25T16:26:48Z

Build failed

ci/hydra-eval

The v was removed from the filenames.

ShelleyKey and cardano-node requires the reward account public key to be hashed, whereas Jörmungandr requires the raw public key. We initially cope with that directly in the backend-specific packages but it doesn't quite work and the engine also needs to be agnostic to the way accounts are obtained from the wallet's state

And make it log a warning about this feature being temporarily disabled.

Using 28 byte hash for Shelley reward address.

rvl · 2020-06-26T06:27:05Z

Jormungandr integration API specs passed for me locally.

bors r+

1779: Jörmungandr 0.9.0 r=rvl a=KtorZ # Issue Number  # Overview  - 9071b4e 📍 **bump jormungandr.nix to use 0.9.0-rc1** - cc4e904 📍 **re-generate jormungandr arbitrary blocks** - 8005030 📍 **fix missing configuration param & fragment in Jörmungandr Binary** - bf2634f 📍 **bump jormungandr integration to 0.9.0** - cf90092 📍 **bump iohk-nix to get a more recent version of the rust compiler** - 4e835cc 📍 **Fix jormungandr windows zip URL** The v was removed from the filenames. - 99ab316 📍 **align jormungandr error messages for addresses with cardano-node** - 2ae6107 📍 **make chimeric account conversion tight to the underlying key scheme.** ShelleyKey and cardano-node requires the reward account public key to be hashed, whereas Jörmungandr requires the raw public key. We initially cope with that directly in the backend-specific packages but it doesn't quite work and the engine also needs to be agnostic to the way accounts are obtained from the wallet's state - b0dbd2c 📍 **only disable fetching reward account on ShelleyKey** And make it log a warning about this feature being temporarily disabled. Co-authored-by: KtorZ <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>

iohk-bors · 2020-06-26T06:47:09Z

Build failed

ci/hydra-build:required

By giving it more time to run.

rvl · 2020-06-26T07:11:49Z

Fixed a test failure.

bors r+

iohk-bors · 2020-06-26T07:46:52Z

Build succeeded

KtorZ requested a review from piotr-iohk June 18, 2020 17:44

KtorZ self-assigned this Jun 18, 2020

KtorZ force-pushed the KtorZ/jormungandr-0.9.0-rc1 branch from 6087bd1 to fde9e87 Compare June 24, 2020 17:23

KtorZ changed the title ~~Jörmungandr 0.9.0-rc1~~ Jörmungandr 0.9.0 Jun 24, 2020

KtorZ force-pushed the KtorZ/jormungandr-0.9.0-rc1 branch 2 times, most recently from 3df8a5b to a74d5e0 Compare June 24, 2020 18:24

rvl force-pushed the KtorZ/jormungandr-0.9.0-rc1 branch from a74d5e0 to cf90092 Compare June 25, 2020 07:39

iohk-bors bot added a commit that referenced this pull request Jun 25, 2020

Try #1779:

6aa2bb5

KtorZ added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Jun 25, 2020

iohk-bors bot added a commit that referenced this pull request Jun 25, 2020

Try #1779:

3fec8f1

piotr-iohk approved these changes Jun 25, 2020

View reviewed changes

KtorZ force-pushed the KtorZ/jormungandr-0.9.0-rc1 branch from b0dbd2c to 3ca10ed Compare June 25, 2020 16:11

rvl approved these changes Jun 26, 2020

View reviewed changes

KtorZ added 5 commits June 26, 2020 15:35

bump jormungandr.nix to use 0.9.0-rc1

3c5680d

re-generate jormungandr arbitrary blocks

edb7ac3

fix missing configuration param & fragment in Jörmungandr Binary

c28d804

bump jormungandr integration to 0.9.0

27f2c4d

bump iohk-nix to get a more recent version of the rust compiler

8da56ec

rvl and others added 5 commits June 26, 2020 15:35

Fix jormungandr windows zip URL

4e29169

The v was removed from the filenames.

align jormungandr error messages for addresses with cardano-node

64a8137

only disable fetching reward account on ShelleyKey

75f84e5

And make it log a warning about this feature being temporarily disabled.

Fix rebase merge error (I think)

86e072a

Using 28 byte hash for Shelley reward address.

rvl force-pushed the KtorZ/jormungandr-0.9.0-rc1 branch from 3ca10ed to 86e072a Compare June 26, 2020 05:50

Make spec for Network.getTxParameters less flakey

77a79af

By giving it more time to run.

iohk-bors bot merged commit f4ce22b into master Jun 26, 2020

iohk-bors bot deleted the KtorZ/jormungandr-0.9.0-rc1 branch June 26, 2020 07:46

piotr-iohk mentioned this pull request Jun 26, 2020

TRANS_CREATE_05, TRANS_ESTIMATE_08 and STAKE_POOLS_JOIN_04 fail on Jormungandr #1793

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jörmungandr 0.9.0 #1779

Jörmungandr 0.9.0 #1779

KtorZ commented Jun 18, 2020 •

edited

Loading

rvl commented Jun 25, 2020

rvl commented Jun 25, 2020

KtorZ commented Jun 25, 2020

KtorZ commented Jun 25, 2020

KtorZ commented Jun 25, 2020

piotr-iohk commented Jun 25, 2020 •

edited

Loading

KtorZ commented Jun 25, 2020

KtorZ commented Jun 25, 2020

piotr-iohk left a comment

iohk-bors bot commented Jun 25, 2020

KtorZ commented Jun 25, 2020

iohk-bors bot commented Jun 25, 2020

rvl commented Jun 26, 2020

iohk-bors bot commented Jun 26, 2020

rvl commented Jun 26, 2020

iohk-bors bot commented Jun 26, 2020

Jörmungandr 0.9.0 #1779

Jörmungandr 0.9.0 #1779

Conversation

KtorZ commented Jun 18, 2020 • edited Loading

Issue Number

Overview

rvl commented Jun 25, 2020

rvl commented Jun 25, 2020

KtorZ commented Jun 25, 2020

KtorZ commented Jun 25, 2020

KtorZ commented Jun 25, 2020

piotr-iohk commented Jun 25, 2020 • edited Loading

KtorZ commented Jun 25, 2020

KtorZ commented Jun 25, 2020

piotr-iohk left a comment

Choose a reason for hiding this comment

iohk-bors bot commented Jun 25, 2020

try

Build failed

KtorZ commented Jun 25, 2020

iohk-bors bot commented Jun 25, 2020

Build failed

rvl commented Jun 26, 2020

iohk-bors bot commented Jun 26, 2020

Build failed

rvl commented Jun 26, 2020

iohk-bors bot commented Jun 26, 2020

Build succeeded

KtorZ commented Jun 18, 2020 •

edited

Loading

piotr-iohk commented Jun 25, 2020 •

edited

Loading