Add logging and tracing to shelley integration tests #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
approved these changes
Jun 13, 2020
|
Not finished yet! |
rvl
force-pushed
the
rvl/integration-tests-tracing
branch
4 times, most recently
from
337c299 to
5803d9b
Compare
|
Now it's ready for review... bors try |
tryBuild failed |
rvl
force-pushed
the
rvl/integration-tests-tracing
branch
3 times, most recently
from
8849f8c to
2901e16
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
1754: Add logging and tracing to shelley integration tests r=rvl a=rvl
### Overview
To help debug integration tests cluster issues.
- [x] Add debug tracing around cluster startup and shutdown.
- [x] Allow increasing the minimum log severity for integration tests with an environment variable.
- [x] Make sure all cluster nodes have exactly the same start time. This prevents these errors:
```
[blue:cardano.node.IpSubscription:Error:46] [2020-06-15 15:34:20.86 UTC] [String "Failed to start all required subscriptions",String "[127.0.0.1:3263,127.0.0.1:32865]",String "WithIPList SubscriptionTrace",String "LocalAddresses {laIpv4 = Just 0.0.0.0:0, laIpv6 = Just [::]:0, laUnix = Nothing}"]
```
- [x] Re-enable stake pools in test cluster.
# Comments
To do later:
- Output debug log files for each cardano-node process to the temporary directory — requires [CAD-1247](https://jira.iohk.io/browse/CAD-1247)
- Different hostnames in cardano-node logs — requires IntersectMBO/cardano-node#1278
Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
|
The integration tests are flaky at the moment, due to the problem which #1768 will fix. |
KtorZ
force-pushed
the
rvl/integration-tests-tracing
branch
from
afcff17 to
6f31485
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 19, 2020
1754: Add logging and tracing to shelley integration tests r=rvl a=rvl
### Overview
To help debug integration tests cluster issues.
- [x] Add debug tracing around cluster startup and shutdown.
- [x] Allow increasing the minimum log severity for integration tests with an environment variable.
- [x] Make sure all cluster nodes have exactly the same start time. This prevents these errors:
```
[blue:cardano.node.IpSubscription:Error:46] [2020-06-15 15:34:20.86 UTC] [String "Failed to start all required subscriptions",String "[127.0.0.1:3263,127.0.0.1:32865]",String "WithIPList SubscriptionTrace",String "LocalAddresses {laIpv4 = Just 0.0.0.0:0, laIpv6 = Just [::]:0, laUnix = Nothing}"]
```
- [x] Re-enable stake pools in test cluster.
# Comments
To do later:
- Output debug log files for each cardano-node process to the temporary directory — requires [CAD-1247](https://jira.iohk.io/browse/CAD-1247)
- Different hostnames in cardano-node logs — requires IntersectMBO/cardano-node#1278
Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To help debug integration tests cluster issues.
Comments
To do later: