Fix jormungandr integration tests on Windows and Wine. #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/1283/wintegration-tests
branch
from
6ad3c9d to
2175d09
Compare
11 tasks
|
How come this was passing before? |
@KtorZ These tests were not testing whether the node was working correctly, just that it was running. What happens when the Why these tests do not exit under this circumstance, I do not know, and at this stage we probably don't need to know... |
It was failing with this message printed repeatedly:
Mar 19 23:15:23.900 ERRO trusted-peers cannot be empty. to avoid bootstrap use 'skip_bootstrap: true', task: bootstrap
Mar 19 23:15:23.900 INFO bootstrap attempt #1 failed, trying again in 5 seconds..., task: bootstrap
Then jormungandr would never exit.
rvl
force-pushed
the
rvl/1283/wintegration-tests
branch
from
2175d09 to
d44cc95
Compare
rvl
changed the title
|
Is this still failing? I cannot find a recent run of the jormungandr integration tests
|
|
It would probably still be failing except that I removed jormungandr integration tests from Hydra because we are not running them on Buildkite either. |
Anviking
approved these changes
Apr 7, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
#1283
Overview