Wallet Backend builds and tests on OSX #704
Assignees
Milestone
Comments
iohk-bors bot
added a commit
that referenced
this issue
Oct 24, 2019
766: Run tests in nix release build r=rvl a=rvl Relates to #703 and #704. Base branch is #864 - this should be merged first. # Overview - [x] This enables test suites under the Nix build. - [x] Fixes test cases that used symlinks. - [x] `Cardano.Wallet.Api.TypesSpec` is trying to access a file `/build/core/../../specifications/api/swagger.yaml` which is outside of its package. - [x] Some tests in `cardano-wallet-jormungandr:test:integration` required `jcli`. - [x] Some tests in `cardano-wallet-jormungandr:test:integration` required a writable home directory. - [x] In LauncherSpec the test scripts used `/usr/bin/env`, which is not in the nix-build sandbox, so i made the tests not need external scripts. - [x] Adds macOS tests to the Hydra required jobs. [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-766) # Comments - Symlinks/references to files in other packages won't work with the nix build because when it builds it copies the package source tree to `/build` and builds from there. # Remaining failures These windows-specific failures can be fixed in the next PR. - [ ] `x86_64-pc-mingw32.tests.cardano-wallet-jormungandr.unit.x86_64-linux` expects UTF-8 encoding, but this is not the encoding that Wine is using. - [ ] Windows cross build got broken. We now require a fix for Haskell.nix. - [ ] `cardano-wallet-jormungandr.exe` would fail on windows at startup with ``` NUL: openFile: does not exist (No such file or directory) ``` Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot
added a commit
that referenced
this issue
Nov 11, 2019
964: Add macOS tarball download to Hydra r=KtorZ a=rvl Relates to #704. # Overview - Adds a downloadable macOS tarball to the Hydra jobset. - Fixes closure size/caching issues which were hacked around in #888. (Halves the closure size of the nix-shell, ensures that Buildkite steps are also built in Hydra) - Adds placeholder for a musl libc fully static build. Tools team can help complete it. # Comments - I have tested the binaries on a MacBook Pro with `cardano-wallet-jormungandr launch --genesis-block ...` [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-964#tabs-jobs) [macOS tarball](https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-964/cardano-wallet-jormungandr-macos64/latest) Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot
added a commit
that referenced
this issue
Nov 11, 2019
964: Add macOS tarball download to Hydra r=rvl a=rvl Relates to #704. # Overview - Adds a downloadable macOS tarball to the Hydra jobset. - Fixes closure size/caching issues which were hacked around in #888. (Halves the closure size of the nix-shell, ensures that Buildkite steps are also built in Hydra) - Adds placeholder for a musl libc fully static build. Tools team can help complete it. # Comments - I have tested the binaries on a MacBook Pro with `cardano-wallet-jormungandr launch --genesis-block ...` [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-964#tabs-jobs) [macOS tarball](https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-964/cardano-wallet-jormungandr-macos64/latest) Co-authored-by: Rodney Lorrimar <[email protected]>
|
@rvl Question about: Do we run benchmark on OSX? |
|
@piotr-iohk The benchmark builds ok, but it is not run in the nightly CI job as it is done for Linux. I consider this type of benchmark not worth running on two similar platforms because the results will be more or less the same. However, we really really should bring back the nightly wallet restore acceptance test and benchmark. Because this type of benchmark should be run on multiple platforms. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
cardano-walletultimately results in two binaries as detailed in the root .cabal:Both are command-lines and web server doing "wallet backend stuff", but working with different chain producers.
Decision
At the moment, our CI only produces binary artifacts for linux machines yet, most are using Windows and OSX machines so we ought to be able to produce executables for these targets too. Ideally, our test suites should also run on both platform to ensure that code produced works as expected on these platforms.
The focus is given on
cardano-wallet-jormungandrforcardano-wallet-http-bridgewill be removed soon enough and will not see the lights of production.Acceptance Criteria
cardano-wallet-jormungandrmust compile to OSXcardano-wallet-core:test:unitmust pass on OSXcardano-wallet-cli:test:unitmust pass on OSXbech32:test:unitmust pass on OSXcardano-wallet-jormungandr:test:unitmust pass on OSXcardano-wallet-jormungandr:test:integrationmust pass on OSXcardano-wallet-core:benchmark:dbshould pass on OSXDevelopment Plan
PR
mastermasterQA
x86_64-darwinjobs are green. In particular, tests for the packages listed in the AC.requiredjob is green.requiredjob. These should include tests for packages listed in the AC.The text was updated successfully, but these errors were encountered: