-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB migration tests failing intermittently #1649
Comments
It's due to port 8090 being in use by another running build I think. The migration test should pick a free port to use rather than 8090. |
1662: Use port 9090 on migration tests not to interfere with any wallet tests that run on default port r=piotr-iohk a=piotr-iohk # Issue Number #1649 (comment) # Overview - 9faa90b Use port 9090 on migration tests not to interfere with any wallet tests that run on default port # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Piotr Stachyra <[email protected]>
Closing #1662 should improve stability. |
It seems the same/similar issue occured again despite changing port to non-default
|
@piotr-iohk The port 8090 conflict was still a problem, so changing the port would have fixed that. This other error is due to #1647 I think. |
1676: Bump cardano-node to pioneer-3 r=rvl a=Anviking # Issue None, or #1657 # Overview - [x] I have bumped cardano-node to the `pioneer-3` tag, such that the new friends-and-family testnet works # Comments - `nix-shell` not working yet <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1679: Reduce running time of fee estimation endpoint r=rvl a=rvl ### Issue Number Relates to ADP-283 / #1648. ### Overview The nightly api endpoint latency benchmark got 100× slower for `postTransactionFee`. This fixes it by moving common setup for coin selection outside of the loop. ### Comments ``` Latencies for 10 fixture wallets scenario postTransactionFee - before - 102.2 ms postTransactionFee - after - 4.8 ms ``` 1680: Fix port selection in the db migration tests r=rvl a=rvl ### Issue number Relates to #1649 ### Overview Each migration test running in turn was using the same port. However due to the `SO_LINGER` TCP socket option, the port remains in use for a short time after the wallet server process exits. So use a different port for each test. ### Comments Tested with: nix-build -A migration-tests -o migration-tests && ./migration-tests/runall.sh Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Context
DB migration test seem to be failing intermittently. In last 3 nightly builds (all of them being run on the same revision 655a459) they failed twice, i.e.:
NB 509 - passed (:heavy_check_mark:)
NB 510 - failed (:x:)
NB 511 - failed (:x:)
Test Case
DB migration test
Failure / Counter-example
NB 510
https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/510#60af6023-b991-4dcb-8715-572668288d9f
Seems that Wallet stopped working (?) after migrating from
v2020-04-28
=>v2020-05-06
NB 511
https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/511#e16f28bd-fab4-4d1b-a3a4-51ad7737a67f
This time looks like wallet stopped working at some point on migration
v2020-04-07
=>v2020-05-06
Resolution
QA
The text was updated successfully, but these errors were encountered: