Skip to content

Commit

Permalink
Merge #2413
Browse files Browse the repository at this point in the history
2413: Clarify 'MsgFailedToParseGenesis' with regards to which genesis file is expected. r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->

#2296 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- 21da8b6
  📍 **clarify 'MsgFailedToParseGenesis' with regards to which genesis file is expected**
    We wrote that message a while ago when there was only Byron and therefore a single genesis file. With Shelley (and later Goguen), there's now an ambiguity when speaking about 'a genesis file' so it is better called out explicitly.

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: KtorZ <[email protected]>
  • Loading branch information
iohk-bors[bot] and KtorZ authored Dec 31, 2020
2 parents 571d93a + 21da8b6 commit c08ac82
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lib/shelley/exe/cardano-wallet.hs
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,12 @@ instance ToText MainLog where
MsgShutdownHandler msg' ->
toText msg'
MsgFailedToParseGenesis hint -> T.unwords
[ "Failed to parse genesis configuration. You may want to check the"
, "filepath given via --genesis and make sure it points to a valid"
, "JSON genesis file. Here's (perhaps) some helpful hint:", hint
[ "Failed to parse Byron genesis configuration. You may want to check"
, "the filepath given via --genesis and make sure it points to a "
, "valid JSON Byron genesis file. The genesis file must be Byron, not"
, "Shelley as it used to feed the wallet with the initial blockchain"
, "parameters."
, "Here's (perhaps) some helpful hint:", hint
]

withTracers
Expand Down

0 comments on commit c08ac82

Please sign in to comment.