-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0129? | Governance Identifiers #857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashisherc thanks; looks like a great start & looking forward to introducing this at the next CIP meeting & hope you can be there for an initial discussion: https://hackmd.io/@cip-editors/93
Once this is merged, We would begin work for supporting it for CNTools and Koios API |
SPO Scripts can support it too. But CLI and DB-Sync must also be onboard. For HW-Wallets, such a change will most likely not be implemented until the end of the year, the release cycle from the vendors (not the devs) is horribly slow nowadays. So, the sooner this gets merged and into the pipelines, the better. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashisherc it sounds like you can put the items provided by @rdlrt @gitmachtl on the Implementation plan, which will fill out that section to a bare minimum for continuing review. It needed to be more specific anyway and I think it's even better to have specific ranges of work to focus on.
I would recommend tickboxes for the general categories (operator tooling, developer APIs) and then the projects above as specific examples in tickboxes nested under them.
Also based on @gitmachtl's assessment about hardware wallet support being slow, I think it would help to highlight that in the implementation plan: as a task to bridge with the responsible developers. Therefore I think that section would also be better suited as tickboxes because of the list of things that are already mentioned there (anything done already can be pre-ticked).
If we have an updated Path to Active before Tuesday we can get this again on the CIP meeting agenda & keep this moving along toward merge. Thanks @rdlrt @gitmachtl for the community review & offers of support.
@rphair updated the PR with the implementation plan, please provide context/recommendation for acceptance criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide context/recommendation for acceptance criteria
According to #857 (review) (and pending further recommendations by @Ryun1 @Crypto2099)...
good stuff, AdaStat will definitely support this CIP |
Although I do think this proposal adds values to Cardano tooling for users. I believe at this stage of maturity for governance tooling having competing standards might not be ideal, potentially damaging user experience and compatibility. Id suggest we move to make this standard an "extension" to CIP105, so that it optionally adds to the existing standard, in a backwards compatible way. |
After extensive discussions on CIP105, it was determined that this specification should be its own CIP, as it is not related to CIP105 (which specifies the derivation for new Conway era keys). Confusing this CIP as a backward-compatible extension of CIP105 is a mistake. This CIP establishes a new specification for various Conway era credentials generated using CIP105.
As specified in the CIP, no existing toolings need to do extensive work to support this CIP, they would only have to switch to a proper bech32 prefix. I do not believe it is too much work just to replace |
If this has to go through, sooner the better, to prevent the exact scenario mentioned. Currently the support for conway across tooling is a bit premature, with all exploration of edge cases requiring frequent fixes/changes. More mature the tooling becomes, more resistance there would be for changes later on. |
@ashisherc is about to update it like i described above. |
Hi all, Context
Optionsa) We change CIP-105 to not claim the prefixes. My opinionI oppose a) as it would mean tooling which is "CIP-105 compliant" would now be broken. Myself and others have suggested b) a couple of times. With the current context I think c) is the only possible action. Does anyone object to allowing both CIP105 and CIP129 claim these bech32 prefixes? |
@Ryun1 - from my understanding of the discussion so far (though not a tool developer) I have no objection to option (c) [CIP-105 and CIP-129 both claim the prefixes] and believe it represents the best chance of moving forward as a community over this issue. |
Same. Not perfect, but seems like a way forward. At the very least it makes the CIP recognize that prior state exists and cannot just be erased from documentation. |
@Ryun1 Thanks! This makes a lot of sense. I don't object to c), but I do want to note has the unfortunate and large downside of bringing confusing to users — "Hey, your drep doesn't work" — "Did you use a CIP-129 or CIP-105 compliant wallet?" — "What's a CIP wallet?"? The only solution to that is to also retire one of the standards in the long term, e.g. d) We retire CIP-105 Doesn't have to be now. |
As i suggested above, i am also for c). But i would also go further and add in some information in the CIP-005 documentation for CIP105 entries, that there is now a newer version and that CIP105 might get deprecated in the future. So thats about d) @HeinrichApfelmus suggested. |
Thanks @Ryun1 for the summary 🙏🏻 From my side (considering participation in Cardano's governance, DReps and delegators' needs and so needs tools should support) I would still stress that effectively creating an 'alternative' DRep ID will require DReps and delegators to be aware of both (without any real benefit and reason for them) and it will add extra unnecessary friction to an already complex experience at its early stages. So purely considering the perspective of users of our governance system I see this as a step back. Option C is definitely a way to unblock this easily (just looking at the CIP itself), but even from the rationale and summary in @Ryun1's comment, it doesn't seem the best option for the broader purpose. (So I would still probably support Option B as I understand it) |
@l-br1 in regards of user experience and that "Dreps" must be aware about an other format. In my oppinion its best to do this now, and not wait and sit it out until we have 1000+ DReps on chain. We should not artificially delay the depoyment of a better solution. CIP129 brings bech representation for ActionIDs too. Thats very nice. It also provides the solution to not have to deal with drep credentials, but reduces that to only three from the six. I am a bit biased about this whole topic, because i brought up this issue around 1,5 years ago. But noone reacted and it was passed and so only the direct hashes were implemented from the ledger/node/cli team. When the problem occured again, it was stated that "now its too late". So, i hope we can move forward with this CIP and to provide a reseaonable upgrade path for the Tools that way. |
I vote for option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor notes about leaving the previous prefixes in CIP-105 and flagging them as DEPRECATED instead so that we do not break any existing compatibility with this change. Everything else looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also @ashisherc there is a merge conflict (likely for the last few weeks, since I think it's from #920) that should be resolved in your branch. ... p.s. please without a force push, so we can preserve all the pending changes & edits 🙏
678c2bc
to
33a5bad
Compare
@rphair all conflicts resolved (Pun intended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and satisfy my feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
yea, thanks everyone involved! |
Introduces byte representation along with a bech32 prefixes for different Conway era credentials and identifiers.
This PR includes relevant updates to CIP - 0005, and 0105 (including updated test vector)
(rendered proposal)