Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0050 | Fix relative links #574

Merged

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Aug 2, 2023

Usual problem: not having any screening process or script to find the relative links not prefixed by ./, we will currently run full speed ahead into this when the merged CIP is built on the Developer Portal (see below; cc @katomm @fill-the-fill @rdlrt).

@KtorZ if you have ideas about how to deal with this proactively maybe we can work together to automate the checks somehow. This is one case where the right approach to scripting could save a lot of manual work by editors. 🤔


Error: ENOENT: no such file or directory, open './static/img/cip/./CIP-0050/images/k-effective.png'
... path: './static/img/cip/./CIP-0050/images/k-effective.png'
}

@katomm
Copy link
Member

katomm commented Aug 2, 2023

Thanks for flagging @rphair. To me, this is a problem of how the script on the developer portal side handles things, so the issue should be opened on the developer portal. (we cannot rely* on "3rd party content" to be delivered in a specific syntax)

*although that would help a lot😁

@rphair
Copy link
Collaborator Author

rphair commented Aug 2, 2023

@katomm that's true, but I believe the bare (unprefixed by ./) relative links also don't build properly on cips.cardano.org ... or didn't (maybe @KtorZ can recall). If true this would be at least a short-term argument for addressing the problem at source: since even after this problem is fixed at all destinations, the more qualified pathnames will never become invalid relative to their own README file.

@rphair
Copy link
Collaborator Author

rphair commented Aug 2, 2023

thanks to @katomm & downstream cardano-foundation/developer-portal#1122 some of the heat may be off about this & the long standing similar problems... but we should merge this soon just in case 😇

@rphair rphair merged commit 895a37a into cardano-foundation:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Correction Fixing minor issue or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants