-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend CIP-0001 to cover internationalized content #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done; answers all of my questions last phrased in #539 (comment) except the one that came up in the last hour's CIP meeting; ready to approve otherwise.
Co-authored-by: Robert Phair <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KtorZ as per #539 (comment) we're going to get people leaving the CIP
field out unless it's specified explicitly.
If not considered important to the human reader, and even if not used (as I would think it would be) to accumulate translations along with the originals by site building scripts, this number is ultimately like a primary key in a table that, failing everything else, will line up the CIP with its translation (even if URLs go out of date for instance).
I do wonder if for the |
@Ryun1 how we considered this idea in the rapid-fire discussion at the meeting (and some in the GitHub threads w/@KtorZ afterward) was:
|
I got lost in some of the rapid fire meeting discussions! 🤓 What you described does sound very reasonable to me and I am happy to approve. For the sake of it, I guess the other downside of the current approach is that the only way the naive users can tell if their translation is behind the current CIP is by searching and following the commit trail. But this should not really be much of an issue, since merged CIPs do not change too much, thus translations are not too likely to be out of date quickly or frequenctly. |
Co-authored-by: Robert Phair <[email protected]>
(new addition = Translations section)