Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0060 | Add more optional fields and update state to Active #367

Merged
merged 1 commit into from
Nov 8, 2022
Merged

CIP-0060 | Add more optional fields and update state to Active #367

merged 1 commit into from
Nov 8, 2022

Conversation

AndrewWestberg
Copy link
Contributor

No description provided.

rphair
rphair reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes a typo as well, I can see 😎

CIP-0060/cddl/version-1.cddl Outdated Show resolved Hide resolved
@AndrewWestberg AndrewWestberg force-pushed the amw/music-token-metadata branch from eff2897 to 2593434 Compare October 28, 2022 19:07
@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Oct 28, 2022
rphair
rphair approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are industry standard tags so this addition seems in order.

@KtorZ it seemed from the original discussion that this was about to go Active - if not active already - but still is it recommended that active CIP's mention some example implementations that are currently live?

@rphair rphair requested a review from KtorZ October 28, 2022 19:21
@KtorZ
Copy link
Member

KtorZ commented Nov 8, 2022

Because we missed it when accepting the proposal, @AndrewWestberg may you clarify the acceptance criteria by which we now consider this proposal active? I reckon it is adoption by a certain number of parties / projects; This would need to go as a Path to active top-level section under Rationale (cf: https://github.com/cardano-foundation/CIPs/blob/master/.github/CIP-TEMPLATE.md).

A small list of checked-checkbox will do 🙏

@AndrewWestberg AndrewWestberg force-pushed the amw/music-token-metadata branch from 2593434 to 61ff9d3 Compare November 8, 2022 14:49
@AndrewWestberg
Copy link
Contributor Author

@KtorZ I've added the Path to active section.

@AndrewWestberg AndrewWestberg force-pushed the amw/music-token-metadata branch from 61ff9d3 to 6b8fad7 Compare November 8, 2022 14:51
@KtorZ KtorZ merged commit b04e44b into cardano-foundation:master Nov 8, 2022
@rphair rphair changed the title Add more optional fields. Update state to Active CIP-0060 | Add more optional fields and update state to Active Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@rphair rphair rphair approved these changes

Assignees
No one assigned
Labels
Update Adds content or significantly reworks an existing proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewWestberg @KtorZ @rphair