Cardano URI Scheme #30
Conversation
|
Updated stake pool specific URI scheme CIP in response: 0ca5438 |
Could it be a security option to let users set a recognition word/phrase inside the wallet?
I know not perfect but an option |
|
@gufmar the wallet checksum already plays this role for Yoroi |
PaymentUrls/PaymentUrls.md
Outdated
| @@ -0,0 +1,77 @@ | |||
| --- | |||
| CIP: TODO | |||
PaymentUrls/PaymentUrls.md
Outdated
|
|
||
| An alternative solution to the original problem described above is to use standard URL links in combination with a routing backend system. The routing system is used to redirect to the app's URI. The advantage of this scheme is that it allows to provide a fallback mechanism to handle the case when no application implementing the protocol is installed (for instance, by redirecting to the App Store or Google Play). This is the approach behind iOS Universal Links and Android App Links. In general, it provides a better user experience but requires a centralized system which makes it unsuitable for as a multi-app standard. | ||
|
|
||
| ## Read More |
There was a problem hiding this comment.
Maybe add a link to existing Yoroi implementations as a reference?
There was a problem hiding this comment.
Our implementation is probably too deeply coupled with the rest of our code to serve as a good reference unfortunately
|
@SebastienGllmt it is hard to believe this CIP was put through without including the material in this other CIP as agreed: #25 (comment) |
|
@rphair the CIP is in 'Draft', there is much room to propose and add changes. As noted, Editors have limited bandwidth. Thanks for stepping up where needed, and I suggest you join the (new) CIP-Biweekly calls to be further involved - we're holding them publicly at https://www.crowdcast.io/cips-biweekly |
|
thank you @crptmppt for the confirmation & clarification about what it means to be a "draft" - that's very reassuring. I appreciate the invitation, have subscribed to that channel & will be happy to join your next meeting 😍 |
|
@rphair I'm kind of confused. There are two ways of merging our work:
My strong preference is on (1). At any rate, both options required getting this PR to be merged first. |
|
@SebastienGllmt as we left it, according the agenda resulting from our last conversation, my single-pool link spec was to be included in your own spec (step 3) before the payment spec was merged in as an approved CIP (step 4):
I don't object to the change in plan, if that's what's it takes to keep the pool links included in this CIP going forward, but when observing step 4 happening before step 3 yesterday, after not hearing anything for 2 months, I think I was the one who was confused. Also according to the original plan I would have only created one new PR: for adding the multi-pool spec into this CIP, since the single-pool spec would have been added before your own CIP pull request was merged. Now I will be submitting two new PRs: one immediately for single-pool, and another down the road for multi-pool as we originally planned. Thanks for putting the key component through, and thanks again for allowing the URI scheme for this CIP to carry the stake pool links. I would only insist that my upcoming pull request include a link to the other PR (#25), which has now become a dead end, since it establishes a date on the original request as well as some helpful discussion. |
|
The proposed changes have now been refactored into this new PR: #61 |
This is a specification of what we've already implemented in both the Yoroi Extension and in Yoroi Mobile