Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0062? | Cardano dApp-Wallet Web Bridge Catalyst Extension #296
CIP-0062? | Cardano dApp-Wallet Web Bridge Catalyst Extension #296
Changes from 9 commits
81c7596
e360eb5
ad82668
5cfa051
25fff85
da74c10
3c7db95
8e9d58f
20feaf3
66d8cf1
da063a4
a12b8a6
5dc31ab
dd1a2e8
b6a6b52
532f493
239d943
48acc62
864ef72
52a2d3c
fe0247d
9a98ee6
7336a91
f19d350
bbfce74
d5d50c7
591bb10
d931f42
d8b140b
9a07508
9bba6d6
04edd0c
3db6476
46d6c98
a00b591
0201fd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this sentence imply that the dapp has to always enable first the CIP-30 API and only then request the governance one? On the other hand this sentence
seems to contradict that, hinting that it may not always be the case that CIP-30 is being enabled before CIP-62. Is my understanding that CIP-30 always has to be enabled before CIP-62 correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct @refi93 . I've updated this section, could you have a re-read?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm checking https://github.com/cardano-foundation/CIPs/pull/296/files#diff-d3ac75d45e4e621f6ad95567378e0dc2b671f44d3c32425dda9ca08210e18876R265-R272 but I didn't notice a difference, am I checking perhaps the wrong commit/branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it ties to explain that CIP-30 should be enabled as well, if not so already.
Maybe Is there a reason why it shouldn't?
Yes, that was the idea.
Would it be more clear if i were to remove the section that states:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will there be an API where the wallet could fetch the proposal metadata to show something more user friendly in the confirmation prompt to the user than a list of numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see; this would definitely be easier to implement on the client side.
About some sort of Map<string,string> // <planId, proposalTitle> ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect a similar breakdown for the Voting process, it would make the motivation behind the available calls clearer to the reader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.