CIP-0025: Added version 2 and cddl #267
Conversation
CIP-0025/README.md
Outdated
|
|
||
| metadata_details = | ||
| { | ||
| name : text, |
There was a problem hiding this comment.
We have to be a little careful with this definition since text here isn't the standard "text" in cbor. Instead, Cardano metadata enforces that all text or byte array has a maximum length. We should probably either define these as a special type that matches the same max length or explicitly allow people to use an array to combine chunks together
There was a problem hiding this comment.
Yeah, I just fixed it. name should definitely stay below 64 characters. The ones that can exceed 64 characters have the type string / [* string].
…ch can be a string or array of strings
KtorZ
added
the
Update
There was a problem hiding this comment.
👍 Approving.
@alessandrokonrad perhaps consider moving the CDDL as separate files so they can be linked / downloaded by tools / CI for validation & automation.
Will leave the PR open for a bit, and we'll merge in the next editor bi-weekly at latest.
No description provided.