Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-30 Extension Naming #590

Closed
Ryun1 opened this issue Sep 9, 2023 · 8 comments
Closed

CIP-30 Extension Naming #590

Ryun1 opened this issue Sep 9, 2023 · 8 comments

Comments

@Ryun1
Copy link
Collaborator

Ryun1 commented Sep 9, 2023

Although we live in a world where CIP-30 is the default Cardano wallet-web connector, this may not always be the case, thus explicitly tying CIP-30 extensions to CIP-30 maybe a mistake.

I propose that we include these proposal titles something like "Web-Wallet Bridge", so something like #509 would be named "Governance Web-Wallet Bridge". I am bad at naming, so just wanted to create an issue to start the conversation.

Thoughts?
@rphair @KtorZ @Crypto2099

@rphair
Copy link
Collaborator

rphair commented Sep 9, 2023

I seconded this motion at the CIP meeting this week ✅ but would also suggest that Web-Wallet Bridge or equivalent precede the extension (e.g. Web-Wallet Bridge: Governance) so they all collate together when CIP names are sorted, and so names are taxonomic (beginning generally & ending specifically).

@Ryun1
Copy link
Collaborator Author

Ryun1 commented Sep 10, 2023

@rphair

Youre always good at naming! - Web-Wallet Bridge: xxxx sounds good to me 😎

@rphair
Copy link
Collaborator

rphair commented Sep 16, 2023

@Ryun1 if nobody thinks these new names are out of place (so far the consensus looks in favour), perhaps we can declare this issue closed in meeting # 73 so I'll put it on the agenda.

@Ryun1
Copy link
Collaborator Author

Ryun1 commented Sep 17, 2023

@rphair I agree!

@Ryun1
Copy link
Collaborator Author

Ryun1 commented Sep 19, 2023

The only is that the colon (:) creates a YAML error when in the proposal header. Not sure if this actually a problem though, it may cause author's confusion.

Error in user YAML: (<unknown>): mapping values are not allowed in this context at line 2 column 25

See in rendered CIP-95.

@rphair

@rphair
Copy link
Collaborator

rphair commented Sep 19, 2023

Aha. Colon = mapping syntax. Thanks; I've been trying to narrow that down for the longest time. 🥴

Typographically the best equivalent of a colon would be an em dash (—) but since we should stick to keyboard characters how about a minus sign? @Ryun1 @Crypto2099 @Scitz0

Web-Wallet Bridge - xxxx

@Ryun1
Copy link
Collaborator Author

Ryun1 commented Sep 19, 2023

In CIP editors call 73, we decided to move to use pipe ( | ) character. PR with information to follow.

@rphair
Copy link
Collaborator

rphair commented Sep 19, 2023

Suggested update to CIP naming convention here (along with how we might update CIP-0030 in kind): #594

@Ryun1 Ryun1 closed this as completed Oct 3, 2023
rphair added a commit that referenced this issue May 14, 2024
* CIP-???? | CIP-30 ext: Account public key

A [CIP-30 extension](https://cips.cardano.org/cips/cip30/#cardanowalletnameenableextensionsextensionpromiseapi) that allows for a DApp (if allowed) to fetch the connected account public key. Utilizes yet to-be-merged CIP-30 namespace PR #577.

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* standard form for copyright footer

Co-authored-by: Ryan Williams <[email protected]>

* Update according to #590

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* change delimiter character as per #594

* title delimiter changed to - as per #594 update

* assign CIP number 104

* Updates according to assigned CIP number

* updates according #601

* Move access line to spec section

---------

Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
rphair added a commit that referenced this issue May 28, 2024
* CIP-???? | CIP-30 ext: Bulk transaction signing

Replaces previous PR #443 by adopting CIP-30 extension framework as well as to-be-merged CIP-30 namespace PR #577.

* update api call to use cip namespace

* add checkboxes for items we're not sure are done yet

* word accuracy + grammar

* Mark criteria as completed

* include *all* prior GitHub discussion (2 PRs)

Co-authored-by: Ryan Williams <[email protected]>

* Update according to #590

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Update CIP-XXXX/README.md

Co-authored-by: Ryan Williams <[email protected]>

* Addresses mentioned comments

* change delimiter character as per #594

* title delimiter changed to - as per #594 update

* assign CIP number 103

* Updates according to assigned CIP number

* Updates according to #601

* Update CIP-0103/README.md

Co-authored-by: Ryan <[email protected]>

* Update CIP-0103/README.md

Co-authored-by: Ryan <[email protected]>

* Update CIP-0103/README.md

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Robert Phair <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants