CNTools 10.2.3 #1636

Scitz0 · 2023-04-28T07:17:36Z

Description

When adding multiple HW signing keys in the same command, you need equally many output witness files.

Which issue it fixes?

closes #1634

How has this been tested?

Yes

…erators into alpha

HW signing fix

TrevorBenson · 2023-04-28T17:21:41Z

@Scitz0 This is the error I get when using cntools.sh -b cntools-10.2.3 for registering a Trezor wallet:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 >> WALLET >> REGISTER
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Online mode  -  The default mode to use if all keys are available

Hybrid mode  -  1) Go through steps to build a transaction file
                2) Copy built tx file to offline computer
                3) Sign it using 'Sign Tx' with keys on offline computer
                   (CNTools started in offline mode '-o' without node connection)
                4) Copy the signed tx file back to online computer and submit using 'Submit Tx'

Selected value: [o] Online

# Select wallet to register (only non-registered wallets shown)
Selected wallet: TrezorWallet-extra2 (Funds: 100.000000 Ada)


INFO: follow directions on hardware device to witness the transaction
Warning! A superfluous HW signing file specified (1 of 2), the witness was not created.
Writing to file '/tmp/cnode/cntools/tx.witness_ly3XH3Q1Me'.
Warning! A superfluous output file specified (2 of 2), the file was not written to.
Command failed: transaction sign-witness  Error: Failed to decode neither the cli's serialisation format nor the ledger's CDDL serialisation format. TextEnvelope error: /tmp/cnode/cntools/tx.witness_OnEKXZHZY9: TextEnvelope aeson decode error: Error in $: not enough input
TextEnvelopeCddl error: /tmp/cnode/cntools/tx.witness_OnEKXZHZY9: Could not JSON decode TextEnvelopeCddl file at: /tmp/cnode/cntools/tx.witness_OnEKXZHZY9 Error: Error in $: not enough input

press any key to proceed ..

TrevorBenson · 2023-04-28T23:30:37Z

@Scitz0
I found the following release notes Cardano HW CLI v1.10.0 release notes:

Fixed:

Ledger no longer creates a staking witness for staking key registration certificate (consistently with Trezor)

superfluous witness output files are reported as a warning, missing witness output files are reported as an error

I can sign the tx.raw with both stake.hwsfile AND payment.hwsfile, dropping either results in a problem.
Signing with only stake.hwsfile

Warning! A superfluous HW signing file specified (1 of 1), the witness was not created.
Warning! A superfluous output file specified (1 of 1), the file was not written to.

Signing with only payment.hwsfile

Error: Missing signing file for certificate

Signing with both works, but the current CNTools 10.2.3 also tries to create 2 separate output files per --hw-signing-file which is where the failure about not being written (2 of 2 in the warnings/errors) comes from. After that the transaction assemble tries to use the missing second witness output, and that is where registration breaks down:

2023-04-28 21:22:34 UTC [ACTION] /home/guild/.local/bin/cardano-cli transaction assemble --tx-body-file /tmp/cnode/cntools/tx.raw --witness-file /tmp/cnode/cntools/tx.witness_BbqqQkA1cH --witness-file /tmp/cnode/cntools/tx.witness_QPCyPKlTNi --out-file /tmp/cnode/cntools/tx.signed_1682716954
2023-04-28 21:22:34 UTC [ERROR]  Command failed: transaction sign-witness  Error: Failed to decode neither the cli's serialisation format nor the ledger's CDDL serialisation format. TextEnvelope error: /tmp/cnode/cntools/tx.witness_QPCyPKlTNi: TextEnvelope aeson decode error: Error in $: not enough input
2023-04-28 21:22:34 UTC [ERROR]  TextEnvelopeCddl error: /tmp/cnode/cntools/tx.witness_QPCyPKlTNi: Could not JSON decode TextEnvelopeCddl file at: /tmp/cnode/cntools/tx.witness_QPCyPKlTNi Error: Error in $: not enough input

Taking the above and testing shows one less error when only 1 --out-file is used with both the stake and payment hwsfile's, but it still produces a superfluous warning. This seems unintuitive since this appears to be the correct usage.

$ $ cardano-hw-cli transaction witness --tx-file /tmp/cnode/cntools/tx.raw --hw-signing-file /opt/cardano/cnode/priv/wallet/TrezorWallet-extra2/stake.hwsfile --out-file /tmp/cnode/cntools/tx.witness_9yXrdLBKpl --testnet-magic 141 --hw-signing-file /opt/cardano/cnode/priv/wallet/TrezorWallet-extra2/payment.hwsfile 
Warning! A superfluous HW signing file specified (1 of 2), the witness was not created.
Writing to file '/tmp/cnode/cntools/tx.witness_9yXrdLBKpl'.
$ /home/guild/.local/bin/cardano-cli transaction assemble --tx-body-file /tmp/cnode/cntools/tx.raw --witness-file /tmp/cnode/cntools/tx.witness_9yXrdLBKpl --out-file /tmp/cnode/cntools/tx.signed_XXXXXXXXXX
$ cardano-cli transaction submit --tx-file /tmp/cnode/cntools/tx.signed_XXXXXXXXXX

I then tested deregistration since I submitted the registration manually, deregistration in the 10.2.3 cntools for HW wallets looks good:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 >> WALLET >> DE-REGISTER
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Online mode  -  The default mode to use if all keys are available

Hybrid mode  -  1) Go through steps to build a transaction file
                2) Copy built tx file to offline computer
                3) Sign it using 'Sign Tx' with keys on offline computer
                   (CNTools started in offline mode '-o' without node connection)
                4) Copy the signed tx file back to online computer and submit using 'Submit Tx'

Selected value: [o] Online

# Select wallet to de-register (only registered wallets shown)
Selected wallet: TrezorWallet-extra2 (Funds: 97.998462 Ada)


INFO: follow directions on hardware device to witness the transaction
Writing to file '/tmp/cnode/cntools/tx.witness_hw2pfqOruh'.
Writing to file '/tmp/cnode/cntools/tx.witness_TquRBEiTIv'.
Transaction successfully submitted.

Waiting for new block to be created (timeout = 600 slots, 600s)
INFO: press any key to cancel and return (won't stop transaction)

VOS_ada successfully de-registered from chain!
Key deposit fee that will be refunded : 2.000000 Ada

press any key to proceed ..

Worked just fine. So De Registering requires both the stake.hwsfile and the payment.hwsfile and does not print ANY superfluous messages when witnessing the transaction. This seems odd because doing the same exact thing for registering warns, why not now (rhetorical question, more for the cardano-hw-cli team). It also produces two separate output files instead of one, one for each witness hwsfile. 🤷

I plan to do additional testing on the delegation, but I need to go back through and manually register the wallet again. I'll report back once I go through more multikey transactions, and keep my eyes open for a commit removing the second output file from the witness and input to the assemble.

TrevorBenson · 2023-04-29T20:31:33Z

I opened this ticket upstream w/ VacuumLabs, hopefully it helps clarify the correct steps and/or gets the warning removed entirely vacuumlabs/cardano-hw-cli#163

…r certain types like register. Also add --change-output-key-file to tell HW device that its own key for less intrusive messages on device.

Scitz0 · 2023-04-29T22:09:04Z

ceb621b should fix it so that all types now successfully can be witnessed. Though the warning on registration will still show, you can ignore this for now.

TrevorBenson · 2023-04-29T23:05:00Z

ceb621b should fix it so that all types now successfully can be witnessed. Though the warning on registration will still show, you can ignore this for now.

Confirmed, this looks like a winner. I went ahead and tested both a Ledger and Trezor to confirm cardano-hw-cli produced the expected behaviors.

CNTools 10.2.3

Tested on guild (141) network

Device Trezor Model T

De-Registered account manually registered.
Registered same account.
Delegated account to AHL

Device Ledger Nano X

Registered account
Delegated account to AHL
De-Registered account

The warnings and errors are printed, but the basic transactions all work.

TrevorBenson

LGTM. I went through online and hybrid/offline registration with hardware wallets as well as more multisig pool creation. Each test case resulted in successful transactions submitted to the chain.

TrevorBenson · 2023-04-30T16:14:01Z

Leaving PR for @Scitz0 or @rdlrt to merge as the label is still set for do-not-merge.

cardano-bot and others added 7 commits January 29, 2023 01:05

New release version

ebd331d

Merge branch 'alpha' of https://github.com/cardano-community/guild-op…

86f18a7

…erators into alpha

Merge branch 'alpha' of https://github.com/cardano-community/guild-op…

1746b1f

…erators into alpha

Merge branch 'alpha' of https://github.com/cardano-community/guild-op…

35c4bba

…erators into alpha

Merge branch 'alpha' of https://github.com/cardano-community/guild-op…

3e051c2

…erators into alpha

CNTools 10.2.3

2e55d17

HW signing fix

changelog

fc03506

Scitz0 requested review from rdlrt and TrevorBenson April 28, 2023 07:17

Scitz0 added the do-not-merge label Apr 28, 2023

skip assemble of empty files due to cardano-hw-cli not creating it fo…

ceb621b

…r certain types like register. Also add --change-output-key-file to tell HW device that its own key for less intrusive messages on device.

TrevorBenson approved these changes Apr 30, 2023

View reviewed changes

Scitz0 merged commit 31764e6 into alpha Apr 30, 2023

Scitz0 deleted the cntools-10.2.3 branch April 30, 2023 16:19

TrevorBenson linked an issue Apr 30, 2023 that may be closed by this pull request

Error during registration and failure during delegation with Trezor HW Wallet and CNTools 10.2.2 #1635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CNTools 10.2.3 #1636

CNTools 10.2.3 #1636

Scitz0 commented Apr 28, 2023

TrevorBenson commented Apr 28, 2023

TrevorBenson commented Apr 28, 2023 •

edited

Loading

TrevorBenson commented Apr 29, 2023

Scitz0 commented Apr 29, 2023

TrevorBenson commented Apr 29, 2023

TrevorBenson left a comment

TrevorBenson commented Apr 30, 2023 •

edited

Loading

CNTools 10.2.3 #1636

CNTools 10.2.3 #1636

Conversation

Scitz0 commented Apr 28, 2023

Description

Which issue it fixes?

How has this been tested?

TrevorBenson commented Apr 28, 2023

TrevorBenson commented Apr 28, 2023 • edited Loading

TrevorBenson commented Apr 29, 2023

Scitz0 commented Apr 29, 2023

TrevorBenson commented Apr 29, 2023

CNTools 10.2.3

Tested on guild (141) network

Device Trezor Model T

Device Ledger Nano X

TrevorBenson left a comment

Choose a reason for hiding this comment

TrevorBenson commented Apr 30, 2023 • edited Loading

TrevorBenson commented Apr 28, 2023 •

edited

Loading

TrevorBenson commented Apr 30, 2023 •

edited

Loading