Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto return types, removing => returns #850

Merged
merged 5 commits into from
Sep 27, 2021
Merged

Implement auto return types, removing => returns #850

merged 5 commits into from
Sep 27, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Sep 23, 2021

This implements #826, I think covering everything important there.

Regarding ReturnTypeContext, I broke that out because it started feeling like a significant number of args to be passing around, and I think this makes the association inside type checking clearer.

@jonmeow jonmeow requested a review from a team as a code owner September 23, 2021 22:34
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Sep 23, 2021
Copy link
Contributor Author

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing comments

executable_semantics/syntax/parser.ypp Show resolved Hide resolved
executable_semantics/interpreter/type_checker.h Outdated Show resolved Hide resolved
executable_semantics/interpreter/type_checker.h Outdated Show resolved Hide resolved
executable_semantics/interpreter/type_checker.h Outdated Show resolved Hide resolved
@jonmeow jonmeow merged commit 5fa7dd8 into carbon-language:trunk Sep 27, 2021
@jonmeow jonmeow deleted the auto-return branch September 27, 2021 18:17
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
This implements #826, I think covering everything important there.

Regarding ReturnTypeContext, I broke that out because it started feeling like a significant number of args to be passing around, and I think this makes the association inside type checking clearer.

Co-authored-by: Geoff Romer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants