Generics details 2: adapters, associated types, parameterized interfaces #731

josh11b · 2021-08-11T03:53:46Z

This proposal goes into the details for these features of generics:

adapters: for creating new types compatible with existing types but with different interface implementations
associated types: allowing an interface implementation to specify some types to use in method signatures
interface parameters: creating a family of interfaces, where types can implement more than one

This is a continuation of #553 . It has been summarized in these presentations:

adapters: 1 and 2
associated types and interface parameters

wolffg

Handful of style nits, one place where you could clarify.

docs/design/generics/overview.md

docs/design/generics/terminology.md

docs/design/generics/details.md

docs/design/generics/overview.md

josh11b · 2021-08-18T21:12:59Z

I have updated this proposal to reflect the decision made in #739.

Co-authored-by: Wolff Dobson <[email protected]>

zygoloid

I've only reviewed the first ~half of this for now, more to follow.

docs/design/generics/details.md

Co-authored-by: Richard Smith <[email protected]>

docs/design/generics/details.md

docs/design/generics/overview.md

proposals/p0731.md

Co-authored-by: Richard Smith <[email protected]>

zygoloid

Thanks, I'm very happy with this. I'd like confirmation from the other leads that we're OK with adapter B extends A being permitted even when A is final but that's my only blocking concern.

docs/design/generics/details.md

zygoloid · 2021-09-03T21:25:48Z

docs/design/generics/details.md

+  impl as Printable { ... }
+}
+
+adapter SongByArtist extends Song {


OK. I think this would be useful to explicitly call out. I've made a suggestion below but feel free to ignore it and substitute your own.

Co-authored-by: Richard Smith <[email protected]>

zygoloid

We're happy allowing adapter B for A even if A is final. Filed #813 to analyze this question further, but we don't need to block on it.

…ces (#731) This proposal goes into the details for these features of generics: - adapters: for creating new types compatible with existing types but with different interface implementations - associated types: allowing an interface implementation to specify some types to use in method signatures - interface parameters: creating a family of interfaces, where types can implement more than one This is a continuation of #553 . It has been summarized in these presentations: - adapters: [1](https://docs.google.com/presentation/d/1bg6q0Q9Sk4YpRbNA3D3H34xYtaEO8ScAUNUZK2UTi80/edit?resourcekey=0-6-Y6e1mfRUmHg-Zk65Gc5A#slide=id.gcf40df1c7b_0_37) and [2](https://docs.google.com/presentation/d/17KG0TeJ4OChMRdLJPS8TE_K6SoL4lFy1FUGr2CDzX-A/edit?resourcekey=0-kLnZqd5NrbGSwmbunTyB-A#slide=id.g7a37009490_0_0) - [associated types and interface parameters](https://docs.google.com/presentation/d/19hPpUjxQ0H1lUSLy5QjS2910Cpc7UdNKpF580fFsCGw/edit?resourcekey=0-ky9XGRC1I8X0Ffw6eqh7WQ#slide=id.p) Co-authored-by: Wolff Dobson <[email protected]> Co-authored-by: Richard Smith <[email protected]>

josh11b added the proposal A proposal label Aug 11, 2021

josh11b requested a review from a team August 11, 2021 03:53

google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Aug 11, 2021

josh11b added 14 commits August 10, 2021 20:53

Filling out template with PR 731

9e996e1

Start proposal text

e961002

Fill in details

9199bf7

Start on changes to overview

6887a70

Working on the overview

c7f8b90

Checkpoint progress.

8f6b276

Complete first draft of overview

6d05344

Should let use :! for compile-time constants?

f6341ca

let for associated constants uses :!

2487aca

Rejected deduced interface params

90c3f59

Value patterns rejected alternative

de8408f

Define associated item

3fc2e6d

Link to terminology

0977043

Associated functions -> associated class functions

66a5173

josh11b marked this pull request as ready for review August 12, 2021 13:31

josh11b requested a review from a team as a code owner August 12, 2021 13:31

github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Aug 12, 2021

josh11b mentioned this pull request Aug 12, 2021

Associated type syntax #739

Closed

josh11b added 2 commits August 12, 2021 09:59

Associated type fulfilled by member type

5ba4d7f

Update open questions

84da573

wolffg reviewed Aug 18, 2021

View reviewed changes

Reflect decision on #739, resolve proposal TODOs

b9689c8

josh11b and others added 2 commits August 18, 2021 14:15

Apply suggestions from code review

a092945

Co-authored-by: Wolff Dobson <[email protected]>

Fix formatting

510c088

josh11b added 3 commits August 20, 2021 09:08

Add example to interface params

7c71e49

Less confusing terminology re: type parameters

e5389d2

Non-type interface parameters

2095567

zygoloid reviewed Sep 1, 2021

View reviewed changes

josh11b and others added 5 commits September 1, 2021 13:41

Apply suggestions from code review

2c75fda

Co-authored-by: Richard Smith <[email protected]>

Follow ups from review suggestions

115af6f

singleton_type -> singleton_type_of

af12ceb

Haskell newtype

a14c8a4

Terser syntax question

d29afc8

zygoloid reviewed Sep 1, 2021

View reviewed changes

josh11b and others added 6 commits September 1, 2021 15:48

Implement suggestion

db935d4

Apply suggestions from code review

e3a519b

Co-authored-by: Richard Smith <[email protected]>

Delete non-type generic future work

ef71709

Update proposals/p0731.md

c0eeeb8

Co-authored-by: Richard Smith <[email protected]>

Associated item -> entity

f70fcc8

Rationale for "adapter" over "adaptor"

3c6919f

zygoloid reviewed Sep 3, 2021

View reviewed changes

Apply suggestions from code review

0d1bfcb

Co-authored-by: Richard Smith <[email protected]>

zygoloid approved these changes Sep 3, 2021

View reviewed changes

josh11b added 3 commits September 3, 2021 15:54

No implicit conversion for adapter extends

e3d9d28

Merge remote-tracking branch 'upstream/trunk' into details

b9554ea

Not only associated types rationale

1569940

josh11b merged commit 48d5397 into carbon-language:trunk Sep 5, 2021

josh11b deleted the details branch September 5, 2021 22:50

github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Sep 5, 2021

josh11b mentioned this pull request Feb 25, 2022

associated type syntax mismatch between PR 731 and the design docs #1099

Closed

jonmeow mentioned this pull request Mar 30, 2022

adaptor versus adapter may be harder to spell than we'd like #1159

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generics details 2: adapters, associated types, parameterized interfaces #731

Generics details 2: adapters, associated types, parameterized interfaces #731

josh11b commented Aug 11, 2021 •

edited

Loading

wolffg left a comment

josh11b commented Aug 18, 2021

zygoloid left a comment

zygoloid left a comment

zygoloid Sep 3, 2021

zygoloid left a comment

Generics details 2: adapters, associated types, parameterized interfaces #731

Generics details 2: adapters, associated types, parameterized interfaces #731

Conversation

josh11b commented Aug 11, 2021 • edited Loading

wolffg left a comment

Choose a reason for hiding this comment

josh11b commented Aug 18, 2021

zygoloid left a comment

Choose a reason for hiding this comment

zygoloid left a comment

Choose a reason for hiding this comment

zygoloid Sep 3, 2021

Choose a reason for hiding this comment

zygoloid left a comment

Choose a reason for hiding this comment

josh11b commented Aug 11, 2021 •

edited

Loading