Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var ordering #618

Merged
merged 11 commits into from
Jul 9, 2021
Merged

var ordering #618

merged 11 commits into from
Jul 9, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Jul 2, 2021

Propose the decision from #542, noting implementation from #563

Also integrates some of #339 into variables.md because that's actually how this started, looking for a proposal reference for #542

@jonmeow jonmeow added the proposal A proposal label Jul 2, 2021
@jonmeow jonmeow requested a review from a team July 2, 2021 17:14
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Jul 2, 2021
@jonmeow jonmeow marked this pull request as ready for review July 2, 2021 17:53
@jonmeow jonmeow requested a review from a team as a code owner July 2, 2021 17:53
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Jul 7, 2021
docs/design/variables.md Show resolved Hide resolved
proposals/p0618.md Outdated Show resolved Hide resolved
proposals/p0618.md Outdated Show resolved Hide resolved
proposals/p0618.md Outdated Show resolved Hide resolved
proposals/p0618.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing comments

proposals/p0618.md Outdated Show resolved Hide resolved
docs/design/variables.md Show resolved Hide resolved
Copy link
Contributor Author

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment pass

proposals/p0618.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please go ahead.

proposals/p0618.md Outdated Show resolved Hide resolved
proposals/p0618.md Outdated Show resolved Hide resolved
@jonmeow
Copy link
Contributor Author

jonmeow commented Jul 9, 2021

Accepted Josh's changes and did formatting. Thanks for the approval, I'll merge when checks are done.

@jonmeow jonmeow merged commit db9da84 into carbon-language:trunk Jul 9, 2021
@jonmeow jonmeow deleted the proposal-var-ordering branch July 9, 2021 18:49
@github-actions github-actions bot removed the proposal rfc Proposal with request-for-comment sent out label Jul 9, 2021
@github-actions github-actions bot added the proposal accepted Decision made, proposal accepted label Jul 9, 2021
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
Propose the decision from #542, noting implementation from #563

Also integrates some of #339 into `variables.md` because that's actually how this started, looking for a proposal reference for #542 

Co-authored-by: Richard Smith <[email protected]>
Co-authored-by: josh11b <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants