Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element index init with vptr #4565

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

element index init with vptr #4565

wants to merge 2 commits into from
+128 −10

Conversation

dwblaikie
Copy link
Contributor

@dwblaikie dwblaikie commented Nov 21, 2024 •
edited
Loading

Not sure if this is the most robust way to do it - I guess the alternative is doing name lookup into the dest struct fields too?

@dwblaikie
Baseline test
ae43651
@dwblaikie
Number element access to account for vptr
253ac7b 
Not sure if this is the most robust way to do it - I guess the
alternative is doing name lookup into the dest struct fields too?
@dwblaikie
Copy link
Contributor Author

This closes the other gap mentioned in #4514 (#4515 addressed this issue in a way that #4515 did not/left unanswered)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer Awaiting requested review from geoffromer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dwblaikie