Factor out the common import pattern in import_ref.cpp. #4557
+205
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
commented
Nov 19, 2024
Comment on lines
1677
to
1678
| CARBON_CHECK(import_ir_.types().GetInstId(inst.type_id) == | ||
| SemIR::InstId::BuiltinWitnessType); |
There was a problem hiding this comment.
FIXME: We're assuming this type ID is the same in both IRs here
zygoloid
commented
Nov 19, 2024
| context_.GetBuiltinType(SemIR::BuiltinInstKind::WitnessType), | ||
| .elements_id = elements_id}); | ||
| CARBON_CHECK(import_ir_.types().GetInstId(inst.type_id) == | ||
| SemIR::InstId::BuiltinWitnessType); |
There was a problem hiding this comment.
FIXME: We're assuming this type ID is the same in both IRs here
avoid `std::forward`, manually expand the packs, inline the lambda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily an exploration of how we could simplify the import_ref logic. This is not ready to land; in particular we may want a different mechanism for customization here rather than a bunch of overloads.