Use llvm::any_of instead of std::ranges::any_of #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not intend to use std::ranges in the Carbon implementation due to concerns of compile time cost, largely due to implicit instantiation of types involved in calling and typechecking the functions and their requires clauses. In carbon-language#4539, we converted std::any_of to std::ranges::any_of, but this replaces that with llvm::any_of from llvm/ADT/STLExtras.h. This conversion was suggested by the modernize-use-ranges clang-tidy check. We can keep the check on, and use it to guide conversion to llvm helpers that do similar things (as was done in this CL now). If it's being too confusing, then it can be disabled as well.
jonmeow
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not intend to use std::ranges in the Carbon implementation due to concerns of compile time cost, largely due to implicit instantiation of types involved in calling and typechecking the functions and their requires clauses.
In #4539, we converted std::any_of to std::ranges::any_of, but this replaces that with llvm::any_of from llvm/ADT/STLExtras.h.
This conversion was suggested by the modernize-use-ranges clang-tidy check. We can keep the check on, and use it to guide conversion to llvm helpers that do similar things (as was done in this CL now). If it's being too confusing, then it can be disabled as well.