Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running 'bazel cquery //...' before target-determinator #4531

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Nov 14, 2024

Trying to improve robustness against failures such as here:

WARNING: Download from https://ftp.gnu.org/gnu/m4/m4-1.4.18.tar.xz failed: class java.net.ConnectException Connection refused

Which is coming from the target-determinator invocation:

subprocess.CalledProcessError: Command '['/home/runner/.cache/carbon-lang-scripts/target-determinator', '--bazel=/usr/local/bin/bazelisk', 'a720921dfb99c21f08832663c91a1f9e48a1bcc4']' returned non-zero exit status 1.

My thought is that the bazel cquery should trigger equivalent downloads (equally though, I'd thought the bazel mod deps would do that, so I don't want to give the impression of confidence).

It's harder to inject this into the target-determinator command line, since we'd need something that retries by default.

Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and geed idea to try and force walk stuff while we have retries in place.

@chandlerc chandlerc added this pull request to the merge queue Nov 15, 2024
Merged via the queue into trunk with commit fe5d3ce Nov 15, 2024
17 checks passed
@chandlerc chandlerc deleted the action-test branch November 15, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants