Add builtin for performing checked conversion between integer types. #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
reviewed
Nov 13, 2024
| fn Int32ToUint32(a: i32) -> u32 = "int.convert_checked"; | ||
| fn Uint32ToInt32(a: u32) -> i32 = "int.convert_checked"; | ||
| fn Uint32ToUint32(a: u32) -> u32 = "int.convert_checked"; | ||
| fn IntLiteralToIntLiteral(a: IntLiteral()) -> IntLiteral() = "int.convert_checked"; |
| AddU32(Int32ToUint32(0x7FFF_FFFF), Int32ToUint32(0x7FFF_FFFF)), | ||
| Int32ToUint32(1))); | ||
|
|
||
| // --- sext.carbon |
There was a problem hiding this comment.
Suggested change
| // --- sext.carbon | |
| // --- signed_extend.carbon |
There was a problem hiding this comment.
Done, but sign_extend instead.
josh11b
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prerequisite for switching the type of int literals to be the
IntLiteraltype, add support for performing conversions of in-bounds integer constant values to other integer types in which they fit.This incidentally is our first compile-time-only builtin function, so add very minimal support for compile-time-only functions while we're here.