Fix up busybox detection for relative symlinks #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
changed the title
danakj
approved these changes
Nov 14, 2024
josh11b
approved these changes
Nov 14, 2024
chandlerc
reviewed
Nov 14, 2024
Comment on lines
+40
to
+41
| // Do a path join, to handle relative symlinks. | ||
| info.bin_path = info.bin_path.parent_path() / symlink_target; |
There was a problem hiding this comment.
This only handles relative symlinks. That's certainly what we need at the moment, but do you want to support both? Worth documenting only relative?
There was a problem hiding this comment.
What do you mean "only"? My understanding is this works for absolute, copying from https://en.cppreference.com/w/cpp/filesystem/path/append:
path("foo") / "/bar"; // the result is "/bar" (replaces)There was a problem hiding this comment.
Should have an explicit test though, so sent #4528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling for relative symlinks is new (comment talks about relative symlinks). Relocated to add tests though, to do extra checking of logic.