Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some single-interface restrictions from some uses of facet types #4508

Merged
merged 59 commits into from
Nov 12, 2024
Merged

Remove some single-interface restrictions from some uses of facet types #4508

merged 59 commits into from
Nov 12, 2024

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Nov 11, 2024

No description provided.

@josh11b
Checkpoint progress.
ed679c2
@josh11b
Checkpoint progress.
034f17e
@josh11b
Rewrite constraint type checking
6726770
@josh11b
Checkpoint progress.
a8e98bb
@josh11b
Still has a FIXME, don't know how get a witness from a facet value
39bf354
@josh11b
Revert "Still has a FIXME, don't know how get a witness from a facet …
22b5987 
…value"

This reverts commit 39bf354.
@josh11b
Make tests pass even though accessing the members of .Self is broken
708cb3b
@josh11b
Merge branch 'whereck' into facettype
a4f8f8b
@josh11b
Checkpoint progress.
75825c3
@josh11b
Checkpoint progress.
f1ca0bc
@josh11b
Merge remote-tracking branch 'upstream/trunk' into facettype
f0d4080
@josh11b
Rename
feef023
@josh11b
Checkpoint progress.
946982f
@josh11b
Checkpoint progress.
ff3b3b1
@josh11b
Checkpoint progress.
c8146e8
@josh11b
Fixed constant eval
3984aa1
@josh11b
Merge remote-tracking branch 'upstream/trunk' into facettype
3f38f0a
@josh11b
Merge remote-tracking branch 'upstream/trunk' into facettype
1236a2f
@josh11b
Checkpoint progress.
55a36aa
@josh11b
Merge remote-tracking branch 'upstream/trunk' into facettype
d92fdd6
@josh11b
Checkpoint progress.
023bdf4
@josh11b
Add TODOs
388ef90
@josh11b
Merge remote-tracking branch 'upstream/trunk' into facettype
49b0c97
@josh11b
Checkpoint progress.
94b438a
@josh11b
Checkpoint progress.
490dbff
@josh11b
Checkpoint progress.
bb39d40
@josh11b
Undo changes to tests
04f655e
@josh11b
Merge remote-tracking branch 'upstream/trunk' into nointerface
6dd19cf
@josh11b
Checkpoint progress.
081b738
@josh11b
Checkpoint progress.
c789b40
@josh11b
Checkpoint progress.
757fce3
@josh11b
Checkpoint progress.
d1382be
@josh11b
Checkpoint progress.
8ff2b98
@josh11b
Fix coverage_test
7056f1d
@josh11b
Polish
8beebe6
@josh11b
Merge remote-tracking branch 'upstream/trunk' into nointerface
cdc2524
@josh11b
Checkpoint progress.
0040e3f
@josh11b
Merge remote-tracking branch 'upstream/trunk' into nointerface
be4ef2d
@josh11b
Checkpoint progress.
0fb0fd0
@josh11b
Checkpoint progress.
f6fcca4
@josh11b
Checkpoint progress.
97ef257
@josh11b
Make sure FacetType instructions always get a name
7fb061c
@josh11b
Checkpoint progress.
b867473
@josh11b
Merge remote-tracking branch 'upstream/trunk' into nointerface
5a5fca2
@josh11b
Checkpoint progress.
34c6cf8
@josh11b
Checkpoint progress.
1ea4434
@josh11b
Checkpoint progress.
c86bcba
@josh11b
Add test for multiple extend
e2eb637
@josh11b
Checkpoint progress.
8fbd971
@josh11b
Checkpoint progress.
7b6b260
@josh11b
Merge remote-tracking branch 'upstream/trunk' into type
6d3df83
@josh11b
Checkpoint progress.
c0c4e6d
zygoloid
zygoloid approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you add some test coverage that demonstrates we're checking that each interface in a multi-interface facet type is checked for completeness as appropriate?

@josh11b
Copy link
Contributor Author

josh11b commented Nov 11, 2024

Can you add some test coverage that demonstrates we're checking that each interface in a multi-interface facet type is checked for completeness as appropriate?

We currently have no way to construct a multi-interface facet type.

@josh11b josh11b added this pull request to the merge queue Nov 12, 2024
Merged via the queue into carbon-language:trunk with commit 4f474fa Nov 12, 2024
10 checks passed
@josh11b josh11b deleted the type branch November 12, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

@chandlerc chandlerc Awaiting requested review from chandlerc

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @zygoloid