Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test class with multiple extend #4504

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Nov 7, 2024

Adds coverage for an existing diagnostic. Code appears to work without modification.

@josh11b josh11b requested review from jonmeow and removed request for zygoloid November 7, 2024 23:47
@josh11b
Copy link
Contributor Author

josh11b commented Nov 7, 2024

It is complaining that a test that I thought was succeeding because of no diagnostics is actually failing (and does not start with fail_). I'm investigating.

@jonmeow
Copy link
Contributor

jonmeow commented Nov 8, 2024

You just need library "[[@TEST_NAME]]"

@josh11b
Copy link
Contributor Author

josh11b commented Nov 8, 2024

library "[[@TEST_NAME]]"

Thanks, should be fixed now.

@josh11b
Copy link
Contributor Author

josh11b commented Nov 8, 2024

I just realized some comments need to be updated too.

@josh11b
Copy link
Contributor Author

josh11b commented Nov 8, 2024

I just realized some comments need to be updated too.

Done now.

@jonmeow jonmeow added this pull request to the merge queue Nov 8, 2024
Merged via the queue into carbon-language:trunk with commit bbeb66b Nov 8, 2024
8 checks passed
@josh11b josh11b deleted the extend branch November 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants