Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name empty tuples distinctly in SemIR. #4503

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Nov 7, 2024

Building on #4502, give empty tuple values a distinct name, and also explicitly name tuple types (previously values but not types were named).

@jonmeow
Copy link
Contributor Author

jonmeow commented Nov 7, 2024

To be clear, depends on #4502

Copy link
Contributor

@dwblaikie dwblaikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonmeow jonmeow added this pull request to the merge queue Nov 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024
Building on #4502, give empty tuple values a distinct name, and also
explicitly name tuple types (previously values but not types were
named).
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@jonmeow jonmeow added this pull request to the merge queue Nov 8, 2024
Merged via the queue into carbon-language:trunk with commit 10e256a Nov 8, 2024
8 checks passed
@jonmeow jonmeow deleted the name-empty-tuple branch November 8, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants