Preserve the is_dynamic property of classes when importing them #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test update shows a class derived from an imported base class with a vptr, and without this change the derived class got its own vptr, with this change the derived class can see the base is dynamic, so the derived doesn't need to add a vptr and can rely on the base class's vptr instead. |
jonmeow
approved these changes
Nov 7, 2024
dwblaikie
force-pushed
the
import_is_dynamic
branch
from
ea37caf
to
a176025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test update shows a class derived from an imported base class with a vptr, and without this change the derived class got its own vptr, with this change the derived class can see the base is dynamic, so the derived doesn't need to add a vptr and can rely on the base class's vptr instead.